nitpicks

Author: yungalgo

packages/cli/src/commands/plugins/actions/install.ts

@@ -129,16 +129,26 @@ async function updateCharacterFiles(pluginName: string, opts: AddPluginOptions):
 
   const characterPaths = resolveCharacterPaths(opts.character);
 
+  let hasFailures = false;
+  
   for (const characterPath of characterPaths) {
     try {
       const characterFile = await loadCharacterFile(characterPath);
       await updateCharacterFile(characterFile, pluginName, 'add');
       logger.info(`✅ Added plugin '${pluginName}' to character '${characterFile.character.name}'`);
     } catch (error) {
       logger.error(`Failed to update character file ${characterPath}:`, error);
-      process.exit(1);
+      logger.warn('Plugin was installed but character file update failed.');
+      logger.info('You can manually add the plugin to your character file.');
+      hasFailures = true;
+      // Continue with other character files instead of exiting
     }
   }
+  
+  if (hasFailures) {
+    logger.warn('Some character files could not be updated. Plugin installation was successful.');
+    logger.info(`To manually add the plugin, add "${pluginName}" to the "plugins" array in your character file(s).`);
+  }
 }
 
 /**

packages/cli/src/commands/plugins/actions/installed-plugins.ts

@@ -33,7 +33,8 @@ export async function showInstalledPlugins(characterPaths?: string[]): Promise<v
     const characterFilePaths = await findCharactersFromPaths(parsedPaths);
 
     if (characterFilePaths.size === 0) {
-      console.log('No valid character files found.');
+      console.log('No valid character files found for the specified paths.');
+      console.log('Please check your character paths and try again.');
       return;
     }
 
@@ -86,7 +87,6 @@ export async function showInstalledPlugins(characterPaths?: string[]): Promise<v
       characterPluginMap.set(characterName, plugins);
     } catch (error) {
       // Skip files that can't be loaded
-      continue;
     }
   }
 

packages/cli/src/utils/character-finder.ts

@@ -311,12 +311,8 @@ export async function findCharactersFromPaths(
  * @throws Error if file cannot be read or parsed
  */
 export async function loadCharacterQuietly(filePath: string): Promise<any> {
-  try {
-    const content = fs.readFileSync(filePath, 'utf-8');
-    return JSON.parse(content);
-  } catch (error) {
-    throw error;
-  }
+  const content = fs.readFileSync(filePath, 'utf-8');
+  return JSON.parse(content);
 }
 
 /**
@@ -359,26 +355,26 @@ export function getTsCharacterName(filePath: string): string | null {
     // First, try to find a character object
     // Look for character: { ... name: "..." ... }
     const characterMatch = content.match(/character\s*:\s*{[^}]*name\s*:\s*["'`]([^"'`]+)["'`]/);
-    if (characterMatch && characterMatch[1]) {
+    if (characterMatch?.[1]) {
       return characterMatch[1];
     }
 
     // Look for agents array with character
     const agentsMatch = content.match(/agents\s*:\s*\[[^\]]*character\s*:\s*{[^}]*name\s*:\s*["'`]([^"'`]+)["'`]/);
-    if (agentsMatch && agentsMatch[1]) {
+    if (agentsMatch?.[1]) {
       return agentsMatch[1];
     }
 
     // Look for const characterName: Character = { name: "..." }
     const typedCharMatch = content.match(/const\s+\w+\s*:\s*Character\s*=\s*{[^}]*name\s*:\s*["'`]([^"'`]+)["'`]/);
-    if (typedCharMatch && typedCharMatch[1]) {
+    if (typedCharMatch?.[1]) {
       return typedCharMatch[1];
     }
 
     // Fallback to simple patterns
     for (const pattern of patterns) {
       const match = content.match(pattern);
-      if (match && match[1]) {
+      if (match?.[1]) {
         return match[1];
       }
     }