Merge PR #7845: chore(cloud): post-merge /clean follow-up on lifecycle job code

Author: Shaw

packages/cloud-api/v1/agents/[agentId]/logs/route.ts

@@ -37,7 +37,7 @@ app.get("/", async (c) => {
       identity.organizationId,
     );
     if (!agent) {
-      return c.json({ error: "Agent not found" }, 404);
+      return c.json({ success: false, error: "Agent not found" }, 404);
     }
 
     const rawTail = parseInt(c.req.query("tail") ?? "100", 10);

packages/cloud-api/v1/eliza/agents/[agentId]/resume/route.ts

@@ -174,11 +174,9 @@ async function __hono_POST(
     }
 
     try {
-      // Distinct from `agent_provision` so the daemon can tell a user-
-      // initiated resume from a fresh provision in audit logs, and so a
-      // future `docker start` fast path can hook in without touching
-      // the route. Today executeResume always re-provisions to restore
-      // bridge/health URLs via the sandbox handle.
+      // Distinct job type from `agent_provision` so the daemon can
+      // tell a user-initiated resume from a fresh provision in audit
+      // logs.
       const { job, created } =
         await provisioningJobService.enqueueAgentResumeOnce({
           agentId,

packages/cloud-api/v1/eliza/agents/[agentId]/route.ts

@@ -355,9 +355,6 @@ app.delete("/", async (c) => {
       202,
     );
   } catch (error) {
-    if (error instanceof Error && error.message === "Agent not found") {
-      return c.json({ success: false, error: "Agent not found" }, 404);
-    }
     logger.error("[agent-api] DELETE /agents/:agentId error", { error });
     return failureResponse(c, error);
   }

packages/cloud-shared/src/lib/services/__tests__/provisioning-job-types.test.ts

@@ -22,6 +22,9 @@ describe("JOB_TYPES", () => {
     expect(JOB_TYPES.AGENT_RESTART).toBe("agent_restart");
     expect(JOB_TYPES.AGENT_LOGS).toBe("agent_logs");
     expect(JOB_TYPES.AGENT_SNAPSHOT).toBe("agent_snapshot");
+    // Lock the size so a new entry without a matching assertion above
+    // fails CI instead of being silently under-covered by tests below.
+    expect(Object.keys(JOB_TYPES)).toHaveLength(7);
   });
 
   test("wire values are unique (no two symbols share a string)", () => {

packages/cloud-shared/src/lib/services/provisioning-jobs.ts

@@ -977,7 +977,7 @@ export class ProvisioningJobService {
             await agentSandboxesRepository.update(data.agentId, {
               status: "error",
               error_message: `Provisioning permanently failed after ${job.max_attempts} attempts: ${errorMsg}`,
-            } as Parameters<typeof agentSandboxesRepository.update>[1]);
+            });
             logger.warn("[provisioning-jobs] Marked sandbox as error after permanent failure", {
               jobId: job.id,
               agentId: data.agentId,
@@ -1001,7 +1001,7 @@ export class ProvisioningJobService {
             await agentSandboxesRepository.update(data.agentId, {
               status: "deletion_failed",
               error_message: `Deletion permanently failed after ${job.max_attempts} attempts: ${errorMsg}`,
-            } as Parameters<typeof agentSandboxesRepository.update>[1]);
+            });
             logger.warn(
               "[provisioning-jobs] Marked sandbox as deletion_failed after permanent failure",
               { jobId: job.id, agentId: data.agentId },
@@ -1387,18 +1387,16 @@ export class ProvisioningJobService {
     const provResult = await elizaSandboxService.provision(data.agentId, data.organizationId);
 
     if (!provResult.success) {
-      // Store partial result for debugging
       await jobsRepository.update(job.id, {
-        result: {
+        result: agentProvisionJobResultToRecord({
           cloudAgentId: data.agentId,
           status: provResult.sandboxRecord?.status ?? "error",
           error: provResult.error,
-        },
+        }),
       });
       throw new Error(provResult.error);
     }
 
-    // Mark completed with result
     const jobResult: AgentProvisionJobResult = {
       cloudAgentId: data.agentId,
       status: provResult.sandboxRecord.status,
@@ -1411,7 +1409,6 @@ export class ProvisioningJobService {
       completed_at: new Date(),
     });
 
-    // Fire webhook if configured
     if (job.webhook_url) {
       await this.fireWebhook(job, jobResult);
     }
@@ -1508,7 +1505,7 @@ export class ProvisioningJobService {
 
       await jobsRepository.update(job.id, {
         webhook_status: response.ok ? "delivered" : `failed_${response.status}`,
-      } as Partial<Job>);
+      });
 
       if (!response.ok) {
         logger.warn("[provisioning-jobs] Webhook delivery failed", {
@@ -1525,7 +1522,7 @@ export class ProvisioningJobService {
 
       await jobsRepository.update(job.id, {
         webhook_status: "error",
-      } as Partial<Job>);
+      });
     }
   }
 }