Commit a9c153d
authored
feat(cloud): POST /api/v1/apps/[id]/deploy + GET …/deploy/status (#7804)
* chore(cloud-api): fix codegen path separators on Windows
`_generate-router.mjs` was leaving Windows-style backslash separators in
the result of `path.relative()`, which made `split("/")` collapse every
route path to just "/api" when run from a Windows host. Normalize the
relative path to forward slashes in `fileToHttpPaths`, `importIdent`,
and `importPath` so the generator produces the same output regardless of
host OS. No-op on POSIX.
* feat(cloud-shared): app-deployments service
Backs the new `POST /api/v1/apps/:id/deploy` and
`GET /api/v1/apps/:id/deploy/status` routes. The persisted source of
truth is the `apps` table itself — `deployment_status`,
`production_url`, and `last_deployed_at` columns added in migration
0007. A deployment is identified by `<appId>:<last_deployed_at_iso>`
so the CLI can correlate POST → GET polls without a separate
`deployments` table.
Pure helpers (status enum mapping, deployment-id composition) live in
`app-deployments-helpers.ts` so unit tests can import them without
pulling in the Drizzle-backed `appsService` and the rest of the
runtime.
When a real build/upload service (Vercel or otherwise) lands, this
service becomes the integration boundary — callers will not need to
change.
* feat(cloud): POST /api/v1/apps/[id]/deploy + GET …/deploy/status
Completes the cloud half of `elizaos deploy` (PR #7786). The CLI keel
from that PR drives this endpoint pair: build → upload → POST
/deploy → attach domain → poll GET /deploy/status every 5s until
READY or ERROR (10-minute cap on the CLI side).
Both routes follow the existing `apps/[id]/domains/route.ts` pattern
exactly:
- Hono handler with `requireUserOrApiKeyWithOrg(c)` for auth
- 404 when the app does not exist, 403 when the caller is authed but
not the owning org
- thin wrapper over `appDeploymentsService`; ownership invariant is
enforced at the route layer (mirrors the domains/managed-domains
split)
Request schema lives in a sibling `schema.ts` so unit tests can
import it without pulling in the route's `@/lib/*` aliased imports.
Pure-helper tests under `packages/cloud-api/__tests__/` cover:
- empty body acceptance
- full body shape acceptance
- repoUrl / ref / env value validation
- every enum value of the persisted → public status map
- deployment-id composition (with and without `last_deployed_at`)
Route-level happy-path / auth / not-found scenarios are exercised by
the existing e2e suite once `TEST_API_BASE_URL` is set.
* fix(cloud-shared): import AppDeploymentStatus from schema + drop dead QUEUED variant
Greptile P2 cleanup on PR #7804.
`AppDeploymentStatus` was redefined locally in app-deployments-helpers
despite being exported from `db/schemas/apps`, creating silent drift
risk if the persisted enum gained a new value (e.g. "cancelling"). Now
re-exported via a type-only import so Drizzle runtime is not pulled in.
`QUEUED` was in the public `DeploymentStatus` union but no code path
can ever emit it — PERSISTED_TO_PUBLIC only produces BUILDING / READY /
ERROR / DRAFT. Removed from the public contract.
The 3 remaining P2s (double getById, concurrent build race, surfacing
error field) are design-sized and deferred to the follow-up
build-pipeline wiring PR.
* fix(cloud): include startedAt: null in deploy status no-record branch
The non-null record branch always returns `startedAt`, but the
no-record branch omitted it entirely. A typed CLI client that reads
`response.startedAt` unconditionally would receive `undefined` in
the no-prior-deployment case with no TypeScript error at the call
site (plain JSON). Keep the response shape uniform.
Addresses Greptile round-2 P1 on PR #7804.
* fix(cloud): reject POST /deploy with 409 when a build is already in flight
Two concurrent CLI invocations of `elizaos deploy` both went through
unguarded: createDeployment stamped `last_deployed_at` twice, the
loser's `deploymentId` was immediately stale, and its subsequent GET
/status polls would return the winner's record without any signal
that the original POST got co-opted.
Adds `assertDeployable` helper that throws ApiError(409) when the
app's persisted `deployment_status` is already "building".
`createDeployment` calls it after a (cache-hot) `getById`, so the
race surfaces to the caller as a 409 instead of silently overwriting.
This is a check-then-act guard, not a DB-level lock — a fully race-
free path would do a conditional UPDATE in the apps repo. For the
realistic CLI cadence (invocations seconds apart) this is sufficient.
Addresses Greptile round-1 P2 on PR #7804.
8/8 helper unit tests green.1 parent 8a55615 commit a9c153d
9 files changed
Lines changed: 517 additions & 4 deletions
File tree
- packages
- cloud-api
- __tests__
- src
- v1/apps/[id]/deploy
- status
Lines changed: 87 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
81 | 83 | | |
82 | 84 | | |
83 | 85 | | |
| |||
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
94 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
| 277 | + | |
| 278 | + | |
277 | 279 | | |
278 | 280 | | |
279 | 281 | | |
| |||
1258 | 1260 | | |
1259 | 1261 | | |
1260 | 1262 | | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
1261 | 1268 | | |
1262 | 1269 | | |
1263 | 1270 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
Lines changed: 65 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
0 commit comments