Skip to content

Commit f9ff66e

Browse files
Shawclaude
andcommitted
test: dedupe rename-collapsed env-var setup in lifeops + isolated-config
Same milady→eliza collapse pattern surfaced in additional test files: - apps/app-lifeops/test/lifeops-gmail-chat.live.e2e.test.ts: duplicate ELIZA_STATE_DIR in saveEnv args + duplicate process.env assignments - apps/app-lifeops/test/book-travel.approval.integration.test.ts: same duplicate saveEnv arg + duplicate assignment - packages/app-core/test/helpers/isolated-config.ts: duplicate `const previousElizaConfigPath` declaration (would fail TS parse for any consumer that imports it) + duplicate restore-block Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 97b3478 commit f9ff66e

3 files changed

Lines changed: 0 additions & 12 deletions

File tree

apps/app-lifeops/test/book-travel.approval.integration.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,6 @@ function installApprovalResolutionModelStub(requestId: string, reason: string) {
415415

416416
beforeAll(async () => {
417417
envBackup = saveEnv(
418-
"ELIZA_STATE_DIR",
419418
"ELIZA_STATE_DIR",
420419
"DUFFEL_API_KEY",
421420
"ELIZA_DUFFEL_DIRECT",
@@ -424,7 +423,6 @@ beforeAll(async () => {
424423
path.join(os.tmpdir(), "book-travel-approval-"),
425424
);
426425
process.env.ELIZA_STATE_DIR = stateDir;
427-
process.env.ELIZA_STATE_DIR = stateDir;
428426
process.env.DUFFEL_API_KEY = "duffel-test-key";
429427
process.env.ELIZA_DUFFEL_DIRECT = "1";
430428

apps/app-lifeops/test/lifeops-gmail-chat.live.e2e.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ async function startLiveServer(): Promise<StartedLiveServer> {
219219
const envBackup = saveEnv(
220220
...Object.keys(LIVE_PROVIDER?.env ?? {}),
221221
"ELIZA_STATE_DIR",
222-
"ELIZA_STATE_DIR",
223222
"ELIZA_GOOGLE_OAUTH_DESKTOP_CLIENT_ID",
224223
"PGLITE_DATA_DIR",
225224
);
@@ -228,7 +227,6 @@ async function startLiveServer(): Promise<StartedLiveServer> {
228227
process.env[key] = value;
229228
}
230229
process.env.ELIZA_STATE_DIR = stateDir;
231-
process.env.ELIZA_STATE_DIR = stateDir;
232230
process.env.ELIZA_GOOGLE_OAUTH_DESKTOP_CLIENT_ID = GOOGLE_CLIENT_ID;
233231

234232
const runtimeResult = await createLifeOpsTestRuntime({

packages/app-core/test/helpers/isolated-config.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ export function useIsolatedConfigEnv(
1414
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
1515
const configPath = path.join(tempDir, "eliza.json");
1616
const previousElizaConfigPath = process.env.ELIZA_CONFIG_PATH;
17-
const previousElizaConfigPath = process.env.ELIZA_CONFIG_PATH;
1817

19-
process.env.ELIZA_CONFIG_PATH = configPath;
2018
process.env.ELIZA_CONFIG_PATH = configPath;
2119

2220
return {
@@ -28,12 +26,6 @@ export function useIsolatedConfigEnv(
2826
process.env.ELIZA_CONFIG_PATH = previousElizaConfigPath;
2927
}
3028

31-
if (previousElizaConfigPath === undefined) {
32-
delete process.env.ELIZA_CONFIG_PATH;
33-
} else {
34-
process.env.ELIZA_CONFIG_PATH = previousElizaConfigPath;
35-
}
36-
3729
await fsp
3830
.rm(tempDir, { recursive: true, force: true })
3931
.catch(() => undefined);

0 commit comments

Comments
 (0)