fix(os-rv64): keep release gates source-only honest#7893
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b66d5d8 to
1f3fec9
Compare
Scope is intentionally limited to packages/chip CI/evidence hygiene.
- formatter/type/shellcheck cleanup for current chip gate surfaces
- Yosys synth now builds the required secure boot ROM input after make clean
- IOMMU stub-audit allowlist entries are explicit evidence-gated
non-production boundaries (per docs/evidence/memory/iommu-evidence-gate.yaml),
not completion claims
- board/package gate uses repo-local mechanical intake-template evidence and
accepts current public-source observation records via a date-anchored regex
- e1-phone-board-package-check validators caught up to current evidence:
- check_display_camera_acceptance: include display_alternate_screen_branch_release_gate
- check_routed_layout_readiness_binding / check_first_article_route_execution_order /
check_post_route_validation_binding: add supplier_rfq_response_normalization to
expected_upstream (matches binding YAMLs already citing it)
- check_end_to_end_readiness: pin off_the_shelf_wireless_modules to the stronger
wireless-module-release-execution.yaml anchor
- yamllint indentation disabled only for the chip tree's mixed
generated/KiCad/PyYAML artifacts; schema/content validators still
enforce semantics
- fail-closed claim boundaries preserved; no hardware/silicon/phone/
performance readiness claims added
Local proof (Docker eliza-soc-tools):
make lint typecheck
make clean synth
make e1-phone-board-package-check
make clean ci-fast (ci-fast complete)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Follow-up pushed to unblock the e1-chip lane. Scope is intentionally limited to What changed (
No silicon/hardware/phone/performance/production readiness claims added. Fail-closed claim boundaries preserved (3,179 Local proof (Docker
Known CI context
|
…ives Follow-up hygiene wins on top of 76b9dbe. packages/chip/.yamllint.yaml - Replace wholesale 'indentation: disable' with a per-path override. - Indentation is now enforced for hand-authored YAML in the chip tree. - The override list covers exactly the 11 generator-owned files whose PyYAML safe_dump output uses sequence indentation yamllint flags: board/kicad/e1-phone/production/ subtree, three dated audit YAMLs under board/kicad/e1-phone/, and docs/evidence/pd/e1-soc-pd-input-contract.yaml. - Verified by injecting a deliberate mis-indent into a hand-authored file: yamllint catches it; reverting restores a clean exit. packages/chip/scripts/check_e1_phone_board_package.py - check_end_to_end_readiness: pin the two remaining objectives to their authoritative artifacts. - component_height_and_enclosure_step → enclosure-fit-execution-package.yaml - supplier_footprints_pinouts_and_3d_models → supplier-to-kicad-evidence-map.yaml - Both anchors are real v1-schema, fail-closed artifacts with forbidden_claims. - All 9 end-to-end objectives are now pinned (was 7 of 9). Verified: docker run ... make e1-phone-board-package-check (green) docker run ... make clean ci-fast (ci-fast complete) yamllint . (exit 0) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
packages/os/linux/elizaosRV64 release-check targets to the checked-in Python manifest gate instead of the deletedscripts/release-check.shplannedartifact metadata with missing evidence rows until a build archives the ISO plus qemu/GRUB/agent transcriptsmanifest.json.templateis missing, so it cannot emit an ISO/checksum without release metadatadevelop(fa83ddee6f) so this PR includes the current chip/RISC-V test-suite fixes and Shaw's newest chip evidence scaffoldingWhy
After the merged RISC-V cleanup, the active Linux tree is
packages/os/linux/elizaos, not the removedelizaos-debian-riscv64variant. The source tree still had two release-gate drift points: the Makefile called a deleted helper, and the committed RV64 manifest claimed collected qemu/GRUB/agent evidence even though the transcript and ISO are not archived in the repo. That made source-only validation either miss the stale helper path or fail for the wrong reason.This PR keeps the claim boundary explicit: the checked-in manifest is a planned skeleton, default
release-checkis informational/BLOCKED, strict release-check remains nonzero until real release evidence is present, and qemu-virt summary evidence is not treated as promoted release evidence without the matching transcript/artifact.Validation
Local validation after merging latest
origin/developon 2026-05-23:git diff --check: passbash -n packages/os/linux/elizaos/build.sh: passELIZAOS_STATIC_SOURCE_ONLY=1 ./scripts/static-smoke.shfrompackages/os/linux/elizaos: passmake -C packages/os/linux/elizaos release-check ARCH=riscv64: exits 0 withSTATUS: BLOCKEDmake -C packages/os/linux/elizaos release-check-strict ARCH=riscv64: exits nonzero withSTATUS: BLOCKEDmake -C packages/os/linux/elizaos release-check ARCH=amd64: refuses the RISC-V-specific gatemake -C packages/chip prototype-status-dashboard-check: passmake -C packages/chip chip-os-objective-evidence-matrix: blocked as expected,requirements=43 proven=3 blocked=5 missing=35make -C packages/chip chip-os-report-freshness-test: passpython3 packages/chip/scripts/test_check_prototype_status_dashboard.py: passpython3 packages/chip/scripts/test_os_rv64_chip_boot_contract.py: passpython3 packages/chip/scripts/test_chip_os_report_freshness.py: passmake -C packages/os/linux/elizaos lint: passLocal environment note: this workstation does not currently have Python
jsonschemainstalled, so the release manifest checker reports that as an additional non-strict BLOCKED line locally. The gate still behaves correctly: default release-check is informational, strict release-check fails closed.Not Claimed