refine hide button thingy

Author: teamcons

src/Widgets/ActionBar.vala

@@ -12,6 +12,7 @@
  public class Jorts.ActionBar : Granite.Bin {
 
     public Gtk.ActionBar actionbar;
+    private Gtk.Button list_button;
     public Gtk.MenuButton emoji_button;
     public Gtk.EmojiChooser emojichooser_popover;
     public Gtk.MenuButton menu_button;
@@ -45,7 +46,7 @@
         delete_item.action_name = StickyNoteWindow.ACTION_PREFIX + StickyNoteWindow.ACTION_DELETE;
 
         /* **** RIGHT **** */
-        var list_button = new Gtk.Button () {
+        list_button = new Gtk.Button () {
             icon_name = "view-list-symbolic",
             width_request = 32,
             height_request = 32,
@@ -57,10 +58,6 @@
         list_button.add_css_class ("themedbutton");
         list_button.action_name = StickyNoteWindow.ACTION_PREFIX + StickyNoteWindow.ACTION_TOGGLE_LIST;
 
-        // Hide the list button if user has specified no list item symbol
-        Application.gsettings.changed["list-item-start"].connect (
-            () => {list_button.visible = (Application.gsettings.get_string ("list-item-start") != "");});
-
         emojichooser_popover = new Gtk.EmojiChooser ();
 
         emoji_button = new Gtk.MenuButton () {
@@ -106,6 +103,11 @@
 
         // Randomize-skip emoji icon
         emojichooser_popover.show.connect (on_emoji_popover);
+
+        // Hide the list button if user has specified no list item symbol
+        on_prefix_changed ();
+        Application.gsettings.changed["list-item-start"].connect (on_prefix_changed);
+
     }
 
     /**
@@ -126,4 +128,8 @@
             )
         );
     }
+
+    private void on_prefix_changed () {
+        list_button.visible = (Application.gsettings.get_string ("list-item-start") != "");
+    }
 }

src/Widgets/TextView.vala

@@ -33,15 +33,13 @@ public class Jorts.TextView : Granite.HyperTextView {
         list_item_start = Application.gsettings.get_string ("list-item-start");
         //Application.gsettings.bind ("list-item-start", this, "list-item-start", GLib.SettingsBindFlags.GET);
 
-        Application.gsettings.changed["list-item-start"].connect (
-            () => {list_item_start = Application.gsettings.get_string ("list-item-start");});
-
         keyboard = new Gtk.EventControllerKey ();
         add_controller (keyboard);
         keyboard.key_pressed.connect (on_key_pressed);
         keyboard.key_released.connect (on_key_released);
 
         buffer.notify["cursor_position"].connect (on_cursor_changed);
+        Application.gsettings.changed["list-item-start"].connect (on_prefix_changed);
     }
 
     public void paste () {
@@ -199,14 +197,18 @@ public class Jorts.TextView : Granite.HyperTextView {
         }
     }
 
+    private void on_prefix_changed () {
+        list_item_start = Application.gsettings.get_string ("list-item-start");
+    }
+
     private void on_cursor_changed () {
         Gtk.TextIter start, end;
         buffer.get_selection_bounds (out start, out end);
         start.backward_line ();
         var line_number = (uint8)start.get_line ();
 
-            if (this.has_prefix (line_number)) {
-                print ("YES THIS IS LIST");
-            }
+        if (this.has_prefix (line_number)) {
+            print ("YES THIS IS LIST");
+        }
     }
 }