DRY and future proof by making a custom widget

Author: teamcons

src/Views/PreferencesView.vala

@@ -6,8 +6,6 @@
  */
 
  public class Jorts.PreferencesView : Gtk.Box {
-    public Gtk.Switch scribbly_toggle;
-    public Gtk.Switch hidebar_toggle;
     //public Gtk.Button reset_button;
     private Granite.Toast toast;
     public Gtk.Button close_button;
@@ -41,43 +39,23 @@
 
                 debug ("Built UI. Lets do connects and binds");
 
-                var scribbly_box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 6);
+                var scribbly_box = new Jorts.SettingsSwitch (
+                    _("Make unfocused notes unreadable"),
+                    _("If enabled, unfocused sticky notes become unreadable to protect their content from peeking eyes (Ctrl+H)"),
+                    "scribbly-mode-active");
 
-                scribbly_toggle = new Gtk.Switch () {
-                    halign = Gtk.Align.END,
-                    hexpand = true,
-                    valign = Gtk.Align.CENTER,
-                };
-
-                var scribbly_label = new Granite.HeaderLabel (_("Make unfocused notes unreadable")) {
-                    mnemonic_widget = scribbly_toggle,
-                    secondary_text = _("If enabled, unfocused sticky notes become unreadable to protect their content from peeking eyes (Ctrl+H)")
-                };
-
-                scribbly_box.append (scribbly_label);
-                scribbly_box.append (scribbly_toggle);
                 settingsbox.append (scribbly_box);
 
 
                 /*************************************************/
                 /*               hidebar Toggle                  */
                 /*************************************************/
 
-                var hidebar_box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 6);
-
-                hidebar_toggle = new Gtk.Switch () {
-                    halign = Gtk.Align.END,
-                    hexpand = true,
-                    valign = Gtk.Align.CENTER,
-                };
-
-                var hidebar_label = new Granite.HeaderLabel (_("Hide buttons")) {
-                    mnemonic_widget = hidebar_toggle,
-                    secondary_text = _("If enabled, hides the bottom bar in sticky notes. Keyboard shortcuts will still function (Ctrl+T)")
-                };
+                var hidebar_box = new Jorts.SettingsSwitch (
+                    _("Hide buttons"),
+                    _("If enabled, hides the bottom bar in sticky notes. Keyboard shortcuts will still function (Ctrl+T)"),
+                    "hide-bar");
 
-                hidebar_box.append (hidebar_label);
-                hidebar_box.append (hidebar_toggle);
                 settingsbox.append (hidebar_box);
 
 

src/Widgets/PreferencesWidgets/SettingsSwitch.vala

@@ -0,0 +1,36 @@
+/*
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ * SPDX-FileCopyrightText:  2017-2024 Lains
+ *                          2025 Stella & Charlie (teamcons.carrd.co)
+ *                          2025 Contributions from the ellie_Commons community (github.com/ellie-commons/)
+ */
+
+/**
+* Switch and its explanatory text
+*/
+public class Jorts.SettingsSwitch : Gtk.Box {
+
+    public SettingsSwitch (string name, string explanation, string key) {
+        orientation = Gtk.Orientation.HORIZONTAL;
+        spacing = 6;
+
+        var toggle = new Gtk.Switch () {
+            halign = Gtk.Align.END,
+            hexpand = true,
+            valign = Gtk.Align.CENTER,
+        };
+
+        var label = new Granite.HeaderLabel (name) {
+            mnemonic_widget = toggle,
+            secondary_text = explanation
+        };
+
+        append (label);
+        append (toggle);
+
+        Application.gsettings.bind (
+            key,
+            toggle, "active",
+            SettingsBindFlags.DEFAULT);
+    }
+}

src/Windows/PreferenceWindow.vala

@@ -79,17 +79,6 @@ public class Jorts.PreferenceWindow : Gtk.ApplicationWindow {
         /*              CONNECTS AND BINDS                 */
         /***************************************************/
 
-        Application.gsettings.bind (
-            "scribbly-mode-active",
-            prefview.scribbly_toggle, "active",
-            SettingsBindFlags.DEFAULT);
-
-
-        Application.gsettings.bind (
-            "hide-bar",
-            prefview.hidebar_toggle, "active",
-            SettingsBindFlags.DEFAULT);
-
         //prefview.reset_button.clicked.connect (on_reset);
         prefview.close_button.clicked.connect (() => {close ();});
 

src/meson.build

@@ -20,6 +20,7 @@ sources = files (
     'Widgets' / 'PopoverWidgets' / 'ColorBox.vala',
     'Widgets' / 'PopoverWidgets' / 'MonospaceBox.vala',
     'Widgets' / 'PopoverWidgets' / 'ZoomBox.vala',
+    'Widgets' / 'PreferencesWidgets' / 'SettingsSwitch.vala',
 
     'Views' / 'PopoverView.vala',
     'Views' / 'PreferencesView.vala',