Clipboard indicator should honor privacy settings

[jeremypw]

Files, Terminal and Code already honor privacy settings as far as restoring previously used tabs is concerned for example.
I suggest the clipboard indicator should become inactive (and/or hide) when the "History" privacy setting is "off".

[teamcons]

visibility here is an awkward key to touch. It just hides the indicator but the indicator still slurps the clipboard

we could do like Bluetooth - have a top toggle, which shows a list if active.
And then offload the visibility thing to eventual external tools to manage indicators
what do you think of that idea ?

if one day this goes into main elementary, it may have a toggle in privacy settings but thats a hypothetical.

[jeremypw]

It was my intention to push a PR adding an "active" property which controlled whether the manager maintained the list. I have kept the "visibility" property for now as I did not add it, but I am not sure it is needed. We could just change the icon to show the manager is inactive.

[jeremypw]

I can extend the linked PR to make it so that the indicator ignores the clipboard while not visible.

[jeremypw]

I think we need to establish clear reasons why a user would want to have the indicator (1) invisible or (2) inactive. Privacy is one thing - what are the others?

[teamcons]

the (1) invisible is an ugly workaround to allow people to customize their top bar. I never intended it as anything more than an entry point to curate wingpanel.
however it can play a role like the windows clipboard: it just sits there ready for whenever you need it, and retrieve history
so either you need it and it is visible, or you dont and you swoosh it away

the (2) inactive i can see User does not like the idea of a process saving up information they copy
--> because it takes CPU and RAM (resource usage)
--> because the idea of a rogue process keeping tabs is uncomfortable (control)
--> because they share the computer and someone may use it same session (privacy)

both are exclusive if they are to play a role as clipboard-indicator functionality, else it would be too much cases (2^2)

[jeremypw]

I guess we need to cater for the case where a computer is used by more than one person, which I tend to forget, otherwise the user can just not install it. Unless elementary core implement a way of showing or hiding individual indicators in settings/Appearance/Dock & Panel for example (which seems unlikely) I guess we will have to make do with a manually edited app setting to always hide it. It doesn't seem worthwhile to include a separate app to manage it. This is separate from the honoring the privacy setting - the app setting would hide the indicator regardless of the privacy setting.

A long time ago I wanted to implement a way of adding app setting plugins into the Settings Panel but it was never taken up.

[jeremypw]

I have now implemented "always-hidden" and "inactive" states in the linked PR. The former is controlled by an app setting. The latter is controlled by the Privacy and Security settings.