Skip to content

Commit a694993

Browse files
committed
chore: Remove last references to xml
1 parent 4a7c5a1 commit a694993

3 files changed

Lines changed: 11 additions & 18 deletions

File tree

Readme.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# LinkedIn API client in PHP
22

33
[![CI Status](https://github.com/elninotech/Linkedin-API-Client/workflows/CI/badge.svg)](https://github.com/elninotech/Linkedin-API-Client/actions)
4-
[![codecov](https://codecov.io/gh/elninotech/Linkedin-API-Client/branch/main/graph/badge.svg?token=0yzBUK8Wri)](https://codecov.io/gh/elninotech/Linkedin-API-Client)
4+
[![codecov](https://codecov.io/github/elninotech/LinkedIn-API-client/graph/badge.svg?token=MN6BEDGUY2)](https://codecov.io/github/elninotech/LinkedIn-API-client)
55
[![Latest Stable Version](https://poser.pugx.org/elninotech/linkedin-api-client/v)](https://packagist.org/packages/elninotech/linkedin-api-client)
66
[![Total Downloads](https://poser.pugx.org/elninotech/linkedin-api-client/downloads)](https://packagist.org/packages/elninotech/linkedin-api-client/stats)
77

@@ -37,7 +37,7 @@ find clients to use. For more information about virtual packages please refer to
3737
[HTTPlug](http://docs.php-http.org/en/latest/httplug/users.html). Example:
3838

3939
```bash
40-
composer require php-http/guzzle6-adapter
40+
composer require php-http/guzzle7-adapter
4141
```
4242

4343
You do also need to install a PSR-7 implementation and a factory to create PSR-7 messages (PSR-17 whenever that is
@@ -78,7 +78,7 @@ an *API Key* and *Secret Key*.
7878

7979
This example below is showing how to login with LinkedIn.
8080

81-
```php
81+
```php
8282
<?php
8383

8484
/**
@@ -162,7 +162,7 @@ The data type returned from `LinkedIn::api` can be configured. You may use the t
162162
$linkedIn=new Elnino\LinkedIn\LinkedIn('app_id', 'app_secret', 'array');
163163

164164
// By setter
165-
$linkedIn->setResponseDataType('simple_xml');
165+
$linkedIn->setResponseDataType('string');
166166

167167
// Set format for just one request
168168
$linkedIn->get('/v2/me/?projection=(id,firstName,lastName)', array('response_data_type'=>'psr7'));
@@ -204,7 +204,11 @@ $url = $linkedIn->getLoginUrl(array('scope'=>$scope));
204204
echo "<a href='$url'>Login with LinkedIn</a>";
205205
```
206206

207+
### Special thanks
208+
209+
This repo was originally created by [Thomas Nyholm from Happyr][forked-from].
207210

208211
[register-app]: https://www.linkedin.com/developers/apps
209212
[api-doc-authentication]: https://learn.microsoft.com/en-us/linkedin/shared/authentication/authentication
210213
[api-doc-core]: https://learn.microsoft.com/en-us/linkedin/shared/api-guide/concepts
214+
[forked-from]: https://github.com/Happyr/LinkedIn-API-client

composer.json

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,10 @@
2929
},
3030
"require-dev": {
3131
"ext-json": "*",
32-
"ext-simplexml": "*",
3332
"illuminate/support": "^12.0",
3433
"mockery/mockery": "^1.0",
3534
"php-http/guzzle7-adapter": "^1.0"
3635
},
37-
"suggest": {
38-
"ext-simplexml": "For encoding and decoding xml requests and responses"
39-
},
4036
"autoload": {
4137
"psr-4": {
4238
"Elnino\\LinkedIn\\": "src/"
@@ -53,9 +49,9 @@
5349
}
5450
},
5551
"scripts": {
56-
"test": "./tools/phpunit",
57-
"phpstan": "./tools/phpstan analyse --memory-limit=-1",
5852
"lint": "./tools/php-cs-fixer check",
59-
"lint-fix": "./tools/php-cs-fixer fix"
53+
"lint-fix": "./tools/php-cs-fixer fix",
54+
"phpstan": "./tools/phpstan analyse --memory-limit=-1",
55+
"test": "./tools/phpunit"
6056
}
6157
}

tests/Http/ResponseConverterTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,6 @@ public function testConvert(): void
3131

3232
$result = ResponseConverter::convert($response, 'array');
3333
$this->assertTrue(is_array($result));
34-
35-
$body = '<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
36-
<person>
37-
<firstname>foo</firstname>
38-
<lastname>bar</lastname>
39-
</person>
40-
';
4134
}
4235

4336
public function testConvertJsonToFoobar(): void

0 commit comments

Comments
 (0)