Skip to content

Commit 6c5e5dc

Browse files
David Garzasfmskywalker
authored andcommitted
Clarify commit strategy fallback behavior in documentation; update test method signature for consistency
1 parent 456e9d1 commit 6c5e5dc

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

  • src/modules/Elsa.Workflows.Core/CommitStates/Extensions
  • test/integration/Elsa.Workflows.IntegrationTests/Scenarios/DefaultWorkflowCommitStrategy

src/modules/Elsa.Workflows.Core/CommitStates/Extensions/ModuleExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public static WorkflowsFeature UseCommitStrategies(this WorkflowsFeature workflo
2323

2424
/// <summary>
2525
/// Sets the specified workflow commit strategy as the global default for all workflows that do not specify their own strategy.
26-
/// The strategy will be automatically registered if not already present.
26+
/// The strategy will not be added to the registry and serves only as a fallback.
2727
/// </summary>
2828
/// <param name="workflowsFeature">The workflows feature.</param>
2929
/// <param name="strategy">The workflow commit strategy instance to use as the default.</param>
@@ -36,7 +36,7 @@ public static WorkflowsFeature WithDefaultWorkflowCommitStrategy(this WorkflowsF
3636

3737
/// <summary>
3838
/// Sets the specified activity commit strategy as the global default for all activities that do not specify their own strategy.
39-
/// The strategy will be automatically registered if not already present.
39+
/// The strategy will not be added to the registry and serves only as a fallback.
4040
/// </summary>
4141
/// <param name="workflowsFeature">The workflows feature.</param>
4242
/// <param name="strategy">The activity commit strategy instance to use as the default.</param>

test/integration/Elsa.Workflows.IntegrationTests/Scenarios/DefaultWorkflowCommitStrategy/Tests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ public async Task NoCommitsWithoutAnyWorkflowCommitStrategy()
116116
}
117117

118118
[Fact(DisplayName = "Default workflow strategy is not visible in commit strategy registry")]
119-
public async Task DefaultWorkflowStrategyNotInRegistry()
119+
public void DefaultWorkflowStrategyNotInRegistry()
120120
{
121121
// Arrange
122122
var services = new TestApplicationBuilder(_testOutputHelper)

0 commit comments

Comments
 (0)