adding validation for converting non oracle to oracle pool (#1266)

Author: avkr003

x/amm/keeper/msg_server_update_pool_params.go

@@ -2,6 +2,7 @@ package keeper
 
 import (
 	"context"
+	"fmt"
 
 	errorsmod "cosmossdk.io/errors"
 	sdk "github.com/cosmos/cosmos-sdk/types"
@@ -12,7 +13,7 @@ import (
 )
 
 // UpdatePoolParams updates the pool params
-func (k Keeper) UpdatePoolParams(ctx sdk.Context, poolId uint64, poolParams types.PoolParams) (uint64, types.PoolParams, error) {
+func (k Keeper) UpdatePoolParams(ctx sdk.Context, poolId uint64, newPoolParams types.PoolParams) (uint64, types.PoolParams, error) {
 	pool, found := k.GetPool(ctx, poolId)
 	if !found {
 		return 0, types.PoolParams{}, types.ErrPoolNotFound
@@ -24,11 +25,41 @@ func (k Keeper) UpdatePoolParams(ctx sdk.Context, poolId uint64, poolParams type
 	}
 
 	// If the fee denom is empty, set it to the base currency
-	if poolParams.FeeDenom == "" {
-		poolParams.FeeDenom = baseCurrency
+	if newPoolParams.FeeDenom == "" {
+		newPoolParams.FeeDenom = baseCurrency
 	}
 
-	pool.PoolParams = poolParams
+	// changing from non-oracle pool to oracle pool
+	if !pool.PoolParams.UseOracle && newPoolParams.UseOracle {
+
+		nonBaseCurrencyDenom := ""
+		usdcDenomFound := false
+
+		for _, asset := range pool.PoolAssets {
+			if asset.Token.Denom != baseCurrency {
+				nonBaseCurrencyDenom = asset.Token.Denom
+			}
+			if asset.Token.Denom == baseCurrency {
+				usdcDenomFound = true
+			}
+		}
+		if !usdcDenomFound {
+			return 0, types.PoolParams{}, fmt.Errorf("no usdc denom in the amm pool %d", poolId)
+		}
+		if nonBaseCurrencyDenom == "" {
+			return 0, types.PoolParams{}, fmt.Errorf("no non-usdc denom in the amm pool %d", poolId)
+		}
+
+		entry, found := k.assetProfileKeeper.GetEntryByDenom(ctx, nonBaseCurrencyDenom)
+		if !found {
+			return 0, types.PoolParams{}, fmt.Errorf("asset profile for %s not found", nonBaseCurrencyDenom)
+		}
+		_, found = k.oracleKeeper.GetAssetPrice(ctx, entry.DisplayName)
+		if !found {
+			return 0, types.PoolParams{}, fmt.Errorf("oracle price for %s not found", entry.DisplayName)
+		}
+	}
+	pool.PoolParams = newPoolParams
 	k.SetPool(ctx, pool)
 	return pool.PoolId, pool.PoolParams, nil
 }