micro optimization for 10^n (#1277)

Co-authored-by: Amit Yadav <amy29981@gmail.com>

Author: avkr003

utils/math.go

@@ -40,6 +40,9 @@ func Pow10(decimal uint64) osmomath.BigDec {
 	return value
 }
 
+// Pow10Int64 returns 10 raised to the power of the input decimal value as an int64.
+// Panics if decimal is greater than 18.
+// Way faster than Pow10 (100x)
 func Pow10Int64(decimal uint64) int64 {
 	if decimal <= 18 {
 		return pow10Int64Cache[decimal]

x/amm/keeper/estimate_price.go

@@ -90,6 +90,7 @@ func (k Keeper) CalculateUSDValue(ctx sdk.Context, denom string, amount math.Int
 	return osmomath.BigDecFromSDKInt(amount).Mul(tokenPrice)
 }
 
+// CalcAmmPrice Panics if decimal is > 18, but we do not support >18 as per AddAssetEntry in AssetProfile
 func (k Keeper) CalcAmmPrice(ctx sdk.Context, denom string, decimal uint64) osmomath.BigDec {
 	usdcDenom, found := k.assetProfileKeeper.GetUsdcDenom(ctx)
 	if !found || denom == usdcDenom {
@@ -102,7 +103,7 @@ func (k Keeper) CalcAmmPrice(ctx sdk.Context, denom string, decimal uint64) osmo
 	}
 
 	routes := resp.InRoute
-	tokenIn := sdk.NewCoin(denom, math.NewInt(utils.Pow10(decimal).TruncateInt64()))
+	tokenIn := sdk.NewCoin(denom, math.NewInt(utils.Pow10Int64(decimal)))
 	discount := osmomath.OneBigDec()
 	spotPrice, _, _, _, _, _, _, _, err := k.CalcInRouteSpotPrice(ctx, tokenIn, routes, discount, osmomath.ZeroBigDec())
 	if err != nil {

x/assetprofile/types/errors.go

@@ -9,6 +9,6 @@ var (
 	ErrAssetProfileNotFound          = errors.Register(ModuleName, 1, "asset profile not found for denom")
 	ErrChannelIdAndDenomHashMismatch = errors.Register(ModuleName, 2, "channel id and denom hash mismatch")
 	ErrNotValidIbcDenom              = errors.Register(ModuleName, 3, "not valid ibc denom")
-	ErrDecimalsInvalid               = errors.Register(ModuleName, 4, "decimals have to be a value between 6 and 18")
+	ErrDecimalsInvalid               = errors.Register(ModuleName, 4, "decimals have to be a value between 6 and 18") // utils.Pow10Int64 used everywhere for faster multiplication which panics if >18
 	ErrInvalidBaseDenom              = errors.Register(ModuleName, 5, "invalid base denom")
 )

x/masterchef/keeper/apr_denom.go

@@ -116,7 +116,7 @@ func (k Keeper) CalculateApr(ctx sdk.Context, query *types.QueryAprRequest) (osm
 			if !found {
 				return osmomath.ZeroBigDec(), assetprofiletypes.ErrAssetProfileNotFound
 			}
-			yearlyDexRewardAmount := usdcAmount.MulInt64(365).Quo(utils.Pow10(entry.Decimals))
+			yearlyDexRewardAmount := usdcAmount.MulInt64(365).QuoInt64(utils.Pow10Int64(entry.Decimals))
 
 			apr := yearlyDexRewardAmount.
 				Quo(edenDenomPrice).

x/perpetual/keeper/asset_price.go

@@ -30,11 +30,11 @@ func (k Keeper) GetAssetPriceAndAssetUsdcDenomRatio(ctx sdk.Context, asset strin
 	}
 
 	if info.Decimal < USDCInfo.Decimals {
-		baseUnitMultiplier := utils.Pow10(USDCInfo.Decimals - info.Decimal)
-		return price, price.Quo(USDCPrice).Mul(baseUnitMultiplier), nil
+		baseUnitMultiplier := utils.Pow10Int64(USDCInfo.Decimals - info.Decimal)
+		return price, price.Quo(USDCPrice).MulInt64(baseUnitMultiplier), nil
 	} else {
-		baseUnitMultiplier := utils.Pow10(info.Decimal - USDCInfo.Decimals)
-		return price, price.Quo(USDCPrice).Quo(baseUnitMultiplier), nil
+		baseUnitMultiplier := utils.Pow10Int64(info.Decimal - USDCInfo.Decimals)
+		return price, price.Quo(USDCPrice).QuoInt64(baseUnitMultiplier), nil
 	}
 }
 
@@ -52,10 +52,10 @@ func (k Keeper) ConvertPriceToAssetUsdcDenomRatio(ctx sdk.Context, asset string,
 		return osmomath.ZeroBigDec(), fmt.Errorf("error converting price to base units, asset price %s not found", ptypes.BaseCurrency)
 	}
 	if info.Decimal < USDCInfo.Decimals {
-		baseUnitMultiplier := utils.Pow10(USDCInfo.Decimals - info.Decimal)
-		return price.Quo(USDCPrice).Mul(baseUnitMultiplier), nil
+		baseUnitMultiplier := utils.Pow10Int64(USDCInfo.Decimals - info.Decimal)
+		return price.Quo(USDCPrice).MulInt64(baseUnitMultiplier), nil
 	} else {
-		baseUnitMultiplier := utils.Pow10(info.Decimal - USDCInfo.Decimals)
-		return price.Quo(USDCPrice).Quo(baseUnitMultiplier), nil
+		baseUnitMultiplier := utils.Pow10Int64(info.Decimal - USDCInfo.Decimals)
+		return price.Quo(USDCPrice).QuoInt64(baseUnitMultiplier), nil
 	}
 }

x/tier/keeper/query_get_consolidated_price.go

@@ -47,8 +47,8 @@ func (k Keeper) GetAllPrices(goCtx context.Context, req *types.QueryGetAllPrices
 		if assetEntry.Denom == ptypes.Eden {
 			denom = ptypes.Elys
 		}
-		tokenPriceOracle := k.oracleKeeper.GetDenomPrice(ctx, denom).Mul(utils.Pow10(assetEntry.Decimals))
-		tokenPriceAmm := k.amm.CalcAmmPrice(ctx, denom, assetEntry.Decimals).Mul(utils.Pow10(assetEntry.Decimals))
+		tokenPriceOracle := k.oracleKeeper.GetDenomPrice(ctx, denom).MulInt64(utils.Pow10Int64(assetEntry.Decimals))
+		tokenPriceAmm := k.amm.CalcAmmPrice(ctx, denom, assetEntry.Decimals).MulInt64(utils.Pow10Int64(assetEntry.Decimals))
 		prices = append(prices, &types.Price{
 			Denom:       assetEntry.Denom,
 			OraclePrice: tokenPriceOracle.Dec(),