Skip to content

Commit d9cadee

Browse files
authored
Vault updates (#1409)
* register missing messages * default param * query fix
1 parent 4a2a08b commit d9cadee

File tree

5 files changed

+13
-18
lines changed

5 files changed

+13
-18
lines changed

x/vaults/keeper/msg_withdraw.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"strings"
66

77
errorsmod "cosmossdk.io/errors"
8+
sdkmath "cosmossdk.io/math"
89
sdk "github.com/cosmos/cosmos-sdk/types"
910
ammtypes "github.com/elys-network/elys/v7/x/amm/types"
1011
"github.com/elys-network/elys/v7/x/vaults/types"
@@ -144,8 +145,7 @@ func (k Keeper) SwapToDepositDenom(ctx sdk.Context, depositDenom string, toSendC
144145
DenomIn: coin.Denom,
145146
DenomOut: depositDenom,
146147
Recipient: recipient.String(),
147-
// MinAmount: sdk.NewInt(0)
148-
// MaxAmount: ,
148+
MinAmount: sdk.NewCoin(depositDenom, sdkmath.ZeroInt()),
149149
})
150150
if err != nil {
151151
return nil, err

x/vaults/keeper/query_estimation.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@ func (k Keeper) DepositEstimation(goCtx context.Context, req *types.QueryDeposit
2121
}
2222

2323
redemptionRate := k.CalculateRedemptionRateForVault(ctx, vault.Id)
24-
var usdValue osmomath.BigDec
24+
usdValue := k.amm.CalculateUSDValue(ctx, vault.DepositDenom, req.Amount)
2525
var shareAmount sdkmath.Int
2626
if redemptionRate.IsZero() {
27-
usdValue = k.amm.CalculateUSDValue(ctx, vault.DepositDenom, req.Amount)
2827
if usdValue.IsZero() {
2928
return nil, types.ErrDepositValueZero
3029
}

x/vaults/keeper/query_vault.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ func (k Keeper) GetVaultAndData(ctx sdk.Context, vaultId uint64, days uint64) (t
6565
depositDenomUsdValue := k.amm.CalculateUSDValue(ctx, vault.DepositDenom, balance.Amount)
6666
var depositsUsed osmomath.BigDec
6767
if totalDepositsUsd.Equal(depositDenomUsdValue) {
68-
depositsUsed = osmomath.OneBigDec()
68+
depositsUsed = osmomath.ZeroBigDec()
6969
} else {
70-
depositsUsed = depositDenomUsdValue.Quo(totalDepositsUsd.Sub(depositDenomUsdValue))
70+
depositsUsed = osmomath.OneBigDec().Sub(depositDenomUsdValue.Quo(totalDepositsUsd.Sub(depositDenomUsdValue)))
7171
}
7272
positions, err := k.GetVaultPositions(ctx, vaultId)
7373
if err != nil {

x/vaults/types/codec.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
2121
legacy.RegisterAminoMsg(cdc, &MsgUpdateVaultFees{}, "vaults/MsgUpdateVaultFees")
2222
legacy.RegisterAminoMsg(cdc, &MsgUpdateVaultLockupPeriod{}, "vaults/MsgUpdateVaultLockupPeriod")
2323
legacy.RegisterAminoMsg(cdc, &MsgUpdateVaultMaxAmountUsd{}, "vaults/MsgUpdateVaultMaxAmountUsd")
24-
24+
legacy.RegisterAminoMsg(cdc, &MsgClaimRewards{}, "vaults/MsgClaimRewards")
25+
legacy.RegisterAminoMsg(cdc, &MsgUpdateVaultAllowedActions{}, "vaults/MsgUpdateVaultAllowedActions")
2526
}
2627

2728
func RegisterInterfaces(registry cdctypes.InterfaceRegistry) {
@@ -39,6 +40,8 @@ func RegisterInterfaces(registry cdctypes.InterfaceRegistry) {
3940
&MsgUpdateVaultFees{},
4041
&MsgUpdateVaultLockupPeriod{},
4142
&MsgUpdateVaultMaxAmountUsd{},
43+
&MsgClaimRewards{},
44+
&MsgUpdateVaultAllowedActions{},
4245
)
4346
msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)
4447
}

x/vaults/types/params.go

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,34 @@
11
package types
22

33
import (
4-
5-
64
paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
75
)
86

97
var _ paramtypes.ParamSet = (*Params)(nil)
108

11-
12-
139
// ParamKeyTable the param key table for launch module
1410
func ParamKeyTable() paramtypes.KeyTable {
1511
return paramtypes.NewKeyTable().RegisterParamSet(&Params{})
1612
}
1713

1814
// NewParams creates a new Params instance
19-
func NewParams(
20-
) Params {
15+
func NewParams() Params {
2116
return Params{
17+
PerformanceFeeEpochLength: 100,
2218
}
2319
}
2420

2521
// DefaultParams returns a default set of parameters
2622
func DefaultParams() Params {
27-
return NewParams(
28-
)
23+
return NewParams()
2924
}
3025

3126
// ParamSetPairs get the params.ParamSet
3227
func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
33-
return paramtypes.ParamSetPairs{
34-
}
28+
return paramtypes.ParamSetPairs{}
3529
}
3630

3731
// Validate validates the set of params
3832
func (p Params) Validate() error {
3933
return nil
4034
}
41-

0 commit comments

Comments
 (0)