fix: get correct URL for lua-language-server release artifact on Windows (#5006)

* fix: get correct URL for `lua-language-server` release artifact on Windows

Currently, `lua-language-server` installs are done by getting the URLs
to release artifacts by matching the release API response to a hardcoded
string consisting of `platform-architecture.<ARCHIVE_FORMAT>`, with the
`ARCHIVE_FORMAT` itself being hardcoded to always be `.tar.gz`.

Currently, `lua-language-server` releases archives for Windows within a
`.zip` archive instead of `.tar.gz`, which causes the logic to fail on
Windows and send over a `nil` instead to the download function.

Instead of fixing it by updating the hardcoded values, this opts to make
it more dynamic and try to figure out what symbol to send over to the
decompression argument from the downloaded archive's filename, as well
as to only use the platform string to determine which link to find and
follow to download the LSP from, sans archive format suffix.

This SHOULD hold better moving forward, barring any strange issues where
e.g. the release has checksums listed at the top with the
`platform-architecture` string embedded in the filename, but this isn't
guaranteed to be stable forever moving forward unless there's some
consensus around HOW to find artifacts for a particular configuration in
a stable manner.

* don't modify match data

This only cares about whether or not it matches and won't do anything
with the resulting match data.

* condense parentheses

Author: madebyly

clients/lsp-lua.el

@@ -553,34 +553,40 @@ and `../lib` ,exclude `../lib/temp`.
   "Download the latest version of lua-language-server and extract it to
 `lsp-lua-language-server-install-dir'."
   (ignore client update?)
-  (let ((store-path (expand-file-name "lua-language-server-github" lsp-clients-lua-language-server-install-dir)))
-    (lsp-download-install
-     (lambda (&rest _)
-       (set-file-modes lsp-clients-lua-language-server-bin #o0700)
-       (funcall callback))
-     error-callback
-     :url (lsp--find-latest-gh-release-url
-           "https://api.github.com/repos/LuaLS/lua-language-server/releases/latest"
-           (format "%s%s.tar.gz"
-                   (pcase system-type
-                     ('gnu/linux
-                      (pcase (lsp-resolve-value lsp--system-arch)
-                        ('x64     "linux-x64")
-                        ('arm64   "linux-arm64")))
-                     ('darwin
-                      (pcase (lsp-resolve-value lsp--system-arch)
-                        ('x64     "darwin-x64")
-                        ('arm64   "darwin-arm64")))
-                     ('windows-nt
-                      (pcase (lsp-resolve-value lsp--system-arch)
-                        ('x64     "win32-x64")
-                        ('arm64   "win32-ia32")))
-                     (_
-                      (pcase (lsp-resolve-value lsp--system-arch)
-                        ('x64     "linux-x64"))))
-                   (if lsp-lua-prefer-musl "-musl" "")))
-     :store-path store-path
-     :decompress (pcase system-type ('windows-nt :zip) (_ :targz)))))
+  (let ((store-path (expand-file-name "lua-language-server-github" lsp-clients-lua-language-server-install-dir))
+        (url (lsp--find-latest-gh-release-url
+              "https://api.github.com/repos/LuaLS/lua-language-server/releases/latest"
+              (format "%s%s"
+                      (pcase system-type
+                        ('gnu/linux
+                         (pcase (lsp-resolve-value lsp--system-arch)
+                           ('x64     "linux-x64")
+                           ('arm64   "linux-arm64")))
+                        ('darwin
+                         (pcase (lsp-resolve-value lsp--system-arch)
+                           ('x64     "darwin-x64")
+                           ('arm64   "darwin-arm64")))
+                        ('windows-nt
+                         (pcase (lsp-resolve-value lsp--system-arch)
+                           ('x64     "win32-x64")
+                           ('arm64   "win32-ia32")))
+                        (_
+                         (pcase (lsp-resolve-value lsp--system-arch)
+                           ('x64     "linux-x64"))))
+                      (if lsp-lua-prefer-musl "-musl" "")))))
+    (let ((decompress (if (string-match-p "\.zip$" url)
+                          (progn :zip)
+                        (if (string-match-p "\.tar.gz$" url)
+                            (progn :targz)
+                          :gzip))))
+      (lsp-download-install
+       (lambda (&rest _)
+         (set-file-modes lsp-clients-lua-language-server-bin #o0700)
+         (funcall callback))
+       error-callback
+       :url url
+       :store-path store-path
+       :decompress decompress))))
 
 (lsp-register-client
  (make-lsp-client