remove github repo and branch

Author: emad-elsaid

docs/Upgrading.md

@@ -9,3 +9,4 @@ If you were a user for v1 and would like to upgrade to v2 please take the follow
   * Your extension can now check for `xlog.Config.Readonly` instead of `xlog.READONLY` during initialization (extension `Init()`)
   * `Get/Post/Delete/..etc` doesn't accept middlewares parameters anymore
 * The version extension has been removed as it was incomplete. if you are running xlog on the same directory that has `.versions` subdirectories you can remove them by running `rm -rf *.versions`
+* `github.repo` and `github.branch` are removed in favor of `github.url` which is the full URL of the editing. so it should work with other git online editors

extensions/github/main.go

@@ -9,41 +9,33 @@ import (
 )
 
 var editUrl string
-var repo string
-var branch string
 
 func init() {
 	flag.StringVar(&editUrl, "github.url", "", "Repository url for 'edit on Github' quick action e.g https://github.com/emad-elsaid/xlog/edit/master/docs")
-	flag.StringVar(&repo, "github.repo", "", "[Deprecated] Github repository to use for 'edit on Github' quick action e.g https://github.com/emad-elsaid/xlog")
-	flag.StringVar(&branch, "github.branch", "master", "[Deprecated] Github repository branch to use for 'edit on Github' quick action")
 	RegisterExtension(Github{})
 }
 
 type Github struct{}
 
 func (Github) Name() string { return "github" }
-func (Github) Init()        { RegisterQuickCommand(quickCommands) }
-
-func quickCommands(p Page) []Command {
-	if len(repo) == 0 && len(editUrl) == 0 {
-		return nil
+func (Github) Init() {
+	if len(editUrl) == 0 {
+		return
 	}
 
+	RegisterQuickCommand(quickCommands)
+}
+
+func quickCommands(p Page) []Command {
 	return []Command{editOnGithub{page: p}}
 }
 
 type editOnGithub struct {
 	page Page
 }
 
-func (e editOnGithub) Icon() string { return "fa-brands fa-github" }
-func (e editOnGithub) Name() string { return "Edit on Github" }
-func (e editOnGithub) Link() string {
-	if len(editUrl) > 0 {
-		return fmt.Sprintf("%s/%s", editUrl, e.page.FileName())
-	} else {
-		return fmt.Sprintf("%s/edit/%s/%s", repo, branch, e.page.FileName())
-	}
-}
+func (e editOnGithub) Icon() string          { return "fa-brands fa-github" }
+func (e editOnGithub) Name() string          { return "Edit on Github" }
+func (e editOnGithub) Link() string          { return fmt.Sprintf("%s/%s", editUrl, e.page.FileName()) }
 func (e editOnGithub) OnClick() template.JS  { return "" }
 func (e editOnGithub) Widget() template.HTML { return "" }