Skip to content

Need advice on PR. #5227

@NeoHylde

Description

@NeoHylde

I'm currently working on a small PR for the can module for embassy-stm32, this would make all of the examples fail build, and would be pretty tedious to go through and fix (or just bloat the pr).

Would you recommend creating new functions and let existing functions be, s.t. examples pass build, or change existing functions?

For context my PR would change the return type of all can::read's to Envelope/FdEnvelope instead of being wrapped in an Option.

fyi I am fairly new to contributing to open source so excuse the low expertise :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions