Skip to content

Commit b436d50

Browse files
authored
add config for the ASMDataTable string pooling (#165)
1 parent 4155494 commit b436d50

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

src/main/java/org/embeddedt/archaicfix/asm/Mixin.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public enum Mixin implements IMixins {
4747
"core.MixinStructureStart",
4848
"core.MixinOreDictionary",
4949
"core.MixinChunkProviderHell",
50-
"core.MixinASMData",
5150
"core.MixinNetHandlerPlayServer")
5251
.addClientMixins(
5352
"core.MixinThreadDownloadImageData",
@@ -171,8 +170,13 @@ public enum Mixin implements IMixins {
171170
.setApplyIf(() -> ArchaicConfig.itemLagReduction)
172171
.addCommonMixins("core.MixinEntityItem")),
173172

174-
MIXINMODCANDIDATE(new ArchaicBuilder()
173+
CANONICALIZE_ASMDATA_TABLE(new ArchaicBuilder()
175174
.setPhase(Phase.EARLY)
175+
.setApplyIf(() -> ArchaicConfig.canonicalizeASMDataTable)
176+
.addCommonMixins("core.MixinASMData")),
177+
CANONICALIZE_ASMDATA_TABLE_NOCOFH(new ArchaicBuilder()
178+
.setPhase(Phase.EARLY)
179+
.setApplyIf(() -> ArchaicConfig.canonicalizeASMDataTable)
176180
.addExcludedMod(TargetedMod.COFHCORE)
177181
.addCommonMixins("core.MixinModCandidate")),
178182

src/main/java/org/embeddedt/archaicfix/config/ArchaicConfig.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,4 +180,8 @@ public class ArchaicConfig {
180180
@Config.Comment("Disable NEI item rendering in AE2 to fix duplicate stack size rendering when using AE2 rv3-beta-6 with NEI > 2.6.37-GTNH")
181181
@Config.DefaultBoolean(false)
182182
public static boolean disableAE2NEIItemRendering;
183+
184+
@Config.Comment("Reduce RAM usage of the ASMDataTable by pooling some of the Strings")
185+
@Config.DefaultBoolean(true)
186+
public static boolean canonicalizeASMDataTable;
183187
}

0 commit comments

Comments
 (0)