Skip to content

Commit 973a5a1

Browse files
authored
fix: metadata getting computed for existing MTEB model (#4231)
* Fix behaviour while getting metadata of existing MTEB model * Added basic metadata in overwrite * Updated CrossEncoderWrapper with same changes
1 parent f913ed8 commit 973a5a1

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

mteb/models/sentence_transformer_wrapper.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,16 @@ def __init__(
7474
self.model = SentenceTransformer(
7575
model, revision=revision, device=device, **kwargs
7676
)
77+
self.mteb_model_meta = ModelMeta.create_empty(
78+
overwrites=dict(
79+
name=model,
80+
revision=revision,
81+
loader=sentence_transformers_loader,
82+
)
83+
)
7784
else:
7885
self.model = model
79-
80-
self.mteb_model_meta = ModelMeta.from_sentence_transformer_model(self.model)
86+
self.mteb_model_meta = ModelMeta.from_sentence_transformer_model(self.model)
8187

8288
built_in_prompts = getattr(self.model, "prompts", None)
8389
if built_in_prompts and not model_prompts:
@@ -291,10 +297,16 @@ def __init__(
291297

292298
if isinstance(model, CrossEncoder):
293299
self.model = model
300+
self.mteb_model_meta = ModelMeta.from_cross_encoder(self.model)
294301
elif isinstance(model, str):
295302
self.model = CrossEncoder(model, revision=revision, device=device, **kwargs)
296-
297-
self.mteb_model_meta = ModelMeta.from_cross_encoder(self.model)
303+
self.mteb_model_meta = ModelMeta.create_empty(
304+
overwrites=dict(
305+
name=model,
306+
revision=revision,
307+
loader=CrossEncoderWrapper,
308+
)
309+
)
298310
self.query_prefix = query_prefix
299311
self.passage_prefix = passage_prefix
300312

0 commit comments

Comments
 (0)