Skip to content

FastBootAppServer duplicates response headers #884

Open
@ghost

Description

FastBootAppServer duplicates response headers which were set by middleware registered in beforeMiddleware hook.

issue-screenshot

I've found that it happens during fastboot-express-middleware execution, here:
https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/packages/fastboot-express-middleware/src/index.js
lines: 44-46

From my perspective, the problem is that code doesn't check already existing response headers before adding new headers from result.headers.

Here, you can find a prepared by me demo of the issue:
https://github.com/yevhenii-pinkal/fastboot-duplicates-headers-issue/tree/master

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions