Merge pull request #108 from aklkv/feature/hbs-linting

turn on template lint

Author: mansona

.template-lintrc.js

@@ -2,7 +2,4 @@
 
 module.exports = {
   extends: 'recommended',
-  ignore: [
-    'addon/**/**/*',
-  ],
 };

addon/components/es-navbar/template.hbs

@@ -1,30 +1,32 @@
 <div class="container">
   {{#bs-navbar
-    backgroundColor='inverse'
-    type='inverse' as |navbar|}}
+    backgroundColor="inverse"
+    type="inverse"
+  as |navbar|
+  }}
     <a class="navbar-brand" href="https://www.emberjs.com">
       {{svg-jar "ember-logo-1c-white"}}
     </a>
     {{navbar.toggle}}
     {{#navbar.content}}
       {{#navbar.nav class="mr-auto" as |nav|}}
         {{#each links as |link|}}
-          {{#if (eq link.type 'link')}}
+          {{#if (eq link.type "link")}}
             {{#nav.item}}
-              <a href="{{link.href}}" class="nav-link">{{link.name}}</a>
+              <a href={{link.href}} class="nav-link">{{link.name}}</a>
             {{/nav.item}}
           {{/if}}
-          {{#if (eq link.type 'dropdown')}}
+          {{#if (eq link.type "dropdown")}}
             {{#nav.dropdown tagName="li" as |dd|}}
               {{#dd.toggle}}{{link.name}} <span class="caret"></span>{{/dd.toggle}}
               {{#dd.menu as |menu|}}
                 {{#each link.items as |item|}}
-                  {{#if (eq item.type 'link')}}
+                  {{#if (eq item.type "link")}}
                     {{#menu.item}}
-                      <a href="{{item.href}}" class="dropdown-item">{{item.name}}</a>
+                      <a href={{item.href}} class="dropdown-item">{{item.name}}</a>
                     {{/menu.item}}
                   {{/if}}
-                  {{#if (eq item.type 'divider')}}
+                  {{#if (eq item.type "divider")}}
                     {{menu.divider}}
                   {{/if}}
                 {{/each}}
@@ -34,24 +36,25 @@
 
         {{/each}}
       {{/navbar.nav}}
-      {{#navbar.nav as |nav|}}
+      {{#navbar.nav}}
         {{#if hasBlock}}
           {{yield}}
         {{else}}
           <form class="navbar-form navbar-right searchbox">
             <div class="input-group">
               <label for="search-input" class="control-label sr-only">Search</label>
-              <input type="text"
-                     class="form-control search input ds-input"
-                     placeholder="Search..."
-                     id="search-input"
-                     role="combobox"
-                     aria-expanded="false"
-                     aria-owns="algolia-autocomplete-listbox-0"
-                     autocorrect="off"
-                     autocapitalize="none"
-                     spellcheck="false"
-              />
+              <input
+                type="text"
+                class="form-control search input ds-input"
+                placeholder="Search..."
+                id="search-input"
+                role="combobox"
+                aria-expanded="false"
+                aria-owns="algolia-autocomplete-listbox-0"
+                autocorrect="off"
+                autocapitalize="none"
+                spellcheck="false"
+              >
               <span></span>
             </div>
           </form>

addon/templates/components/es-accordion/es-item.hbs

@@ -16,7 +16,7 @@
     class="button-icon"
     data-role="accordion-item-button"
     aria-label="expand collapse"
-    aria-expanded="{{isExpanded}}"
+    aria-expanded={{isExpanded}}
   >
     <i class="fa fa-chevron-down" aria-hidden="true"></i>
   </button>

addon/templates/components/es-blog-heading.hbs

@@ -5,6 +5,5 @@
 {{else}}
   <h1 class="post-title page-view">{{postTitle}}</h1>
 {{/if}}
-<div class="post-date">{{moment-format postDate 'MMM DD, YYYY' 'MM-DD-YYYY'}}</div>
+<div class="post-date">{{moment-format postDate "MMM DD, YYYY" "MM-DD-YYYY"}}</div>
 <div class="post-author {{if isGuestPost "guest"}}">By {{author}}</div>
-

addon/templates/components/es-footer.hbs

@@ -1,11 +1,13 @@
 <div class="footer responsive">
   <div class="container">
 
-    {{yield (hash
-        info = (component 'es-footer/es-info')
-        statement = (component 'es-footer/es-statement')
-        contributions = (component 'es-footer/es-contributions')
-    )}}
+    {{yield
+      (hash
+      info = (component "es-footer/es-info")
+      statement = (component "es-footer/es-statement")
+      contributions = (component "es-footer/es-contributions")
+      )
+    }}
 
     {{#unless hasBlock}}
 

addon/templates/components/es-footer/es-info.hbs

@@ -6,9 +6,9 @@ Copyright {{currentYear}}
   {{#each infoLinks as |link index|}}
     <a href={{link.href}}>{{link.name}}</a>
     {{#if link.lineBreak}}
-      <br/>
+      <br>
     {{else if (not-eq index infoLinksLastIndex)}}
-       |
+      |
     {{/if}}
   {{/each}}
 {{/if}}

addon/templates/components/es-heading.hbs

@@ -1,5 +1,5 @@
 {{#if hasBlock}}
-    {{yield}}
+  {{yield}}
 {{else}}
-    {{headingText}}
+  {{headingText}}
 {{/if}}

addon/templates/components/es-main.hbs

@@ -2,7 +2,7 @@
   {{#if hasAside}}
     <div class="row">
       {{#es-aside}}
-      {{!--//aside content--}}
+        {{!--//aside content--}}
       {{/es-aside}}
       <div class="col-xs-12 col-md-8 col-lg-9">
         {{yield}}
@@ -11,4 +11,4 @@
   {{else}}
     {{yield}}
   {{/if}}
-</div>
+</div>

addon/templates/components/es-note.hbs

@@ -9,5 +9,5 @@
       {{/if}}
     </div>
   </div>
-  <img src={{imageUrl}} role="presentation">
+  <img src={{imageUrl}} role="presentation" alt="Ember Mascot">
 </div>

addon/templates/components/es-ulist.hbs

@@ -1,25 +1,25 @@
-<div class="list-title {{if isTitleVisible sr-only}}" id="{{listId}}">{{listTitle}}</div>
+<div class="list-title {{if isTitleVisible sr-only}}" id={{listId}}>{{listTitle}}</div>
+
 {{#if isUnorderedList}}
-    <ul aria-labelledby="{{listId}}" class="list list-default">                
-        {{#each listItems as |item|}}            
-            <li class="list-item">
-                {{#if hasLink}}
-                    <a href="{{item.link}}" class="list-item-link">
-                        {{#if hasImage}}
-                            <img src="{{item.image}}" class="list-item-image" />
-                        {{/if}} 
-                        {{item.text}}
-                    </a>
-                {{else}}
-                    {{#if hasImage}}
-                        <img src="{{item.image}}" class="list-item-image" />
-                    {{/if}}
-                    {{item.text}}
-                {{/if}}
-            </li>
-        {{/each}}
-    </ul>    
+  <ul aria-labelledby={{listId}} class="list list-default">
+    {{#each listItems as |item|}}
+      <li class="list-item">
+        {{#if hasLink}}
+          <a href={{item.link}} class="list-item-link">
+            {{#if hasImage}}
+              <img src={{item.image}} class="list-item-image" alt={{item.alt}}>
+            {{/if}}
+            {{item.text}}
+          </a>
+        {{else}}
+          {{#if hasImage}}
+            <img src={{item.image}} class="list-item-image" alt={{item.alt}}>
+          {{/if}}
+          {{item.text}}
+        {{/if}}
+      </li>
+    {{/each}}
+  </ul>
 {{else}}
-    
-{{/if}}
 
+{{/if}}