Skip to content

Commit 6c7a696

Browse files
authored
Merge pull request #274 from ember-learn/minor-improvements
Minor improvements
2 parents a88228c + 93edb0d commit 6c7a696

File tree

8 files changed

+82
-14
lines changed

8 files changed

+82
-14
lines changed

addon/styles/background-shapes.css

+10
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,13 @@
3232
background-repeat: no-repeat;
3333
background-position: bottom left;
3434
}
35+
36+
@media (max-width: 1007px) {
37+
.bg-shape-boxes-bottom {
38+
background-size: 300px;
39+
}
40+
41+
.bg-shape-boxes-bottom + * {
42+
background-size: 100px;
43+
}
44+
}

addon/styles/components/es-card.css

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
position: relative;
77
}
88

9+
.bg-dark .card {
10+
border-color: var(--color-gray-600);
11+
}
12+
913
.card[card-link] h1 > a::after,
1014
.card[card-link] h2 > a::after,
1115
.card[card-link] h3 > a::after,
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
<div class="es-page-header bg-shape-boxes-bottom" ...attributes>
2-
<div class="container">
3-
<h1 class="text-hero-xl">{{@headline}}</h1>
2+
<div class="container layout">
3+
<div class="lg:col-5">
4+
<h1 class="text-hero-xl">{{@headline}}</h1>
45

5-
<p class="text-hero-base {{if hasBlock "mb-2"}}">{{@detail}}</p>
6+
<p class="text-hero-base {{if hasBlock "mb-2"}}">{{@detail}}</p>
67

7-
{{yield}}
8+
{{yield}}
9+
</div>
810
</div>
9-
</div>
11+
</div>

docs/components/page-header.md

+6
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ should use the `<EsPageHeader />` component:
1212
>
1313
<EsButton>Go</EsButton>
1414
</EsPageHeader>
15+
<section>
16+
<div class="container">
17+
<h2>Next Section</h2>
18+
<p>This is here to show how the bg-shape continues onto the next section</p>
19+
</div>
20+
</section>
1521
```
1622

1723
This example is making use of the [`dark` css helper](/css/helpers#dark)

index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ module.exports = {
3131

3232
svgJar: {
3333
sourceDirs: [
34-
'public',
35-
'node_modules/ember-styleguide/public',
36-
'tests/dummy/public'
34+
'public/images/icons',
35+
'node_modules/ember-styleguide/public/images/icons',
36+
'tests/dummy/public/images/icons'
3737
]
3838
},
3939
},

package-lock.json

+43-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"babel-eslint": "^8.2.6",
4646
"broccoli-asset-rev": "^3.0.0",
4747
"ember-a11y-landmarks": "^1.0.1",
48-
"ember-array-helper": "^5.0.0",
48+
"ember-array-helper": "^5.1.0",
4949
"ember-cli": "~3.10.1",
5050
"ember-cli-dependency-checker": "^3.1.0",
5151
"ember-cli-eslint": "^5.1.0",

public/images/swipe-top.svg

+8-1
Loading

0 commit comments

Comments
 (0)