Skip to content

Commit 2619f7e

Browse files
authored
Merge pull request #1140 from ember-learn/link-teams
add the ability to link to a team on teams page
2 parents 8504666 + 1bc98b3 commit 2619f7e

File tree

5 files changed

+37
-0
lines changed

5 files changed

+37
-0
lines changed

app/components/teams/team.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<h2
22
class="text-center"
33
data-test-field="Team Name"
4+
id={{dasherize @name}}
45
>
56
{{@name}}
67
</h2>

app/helpers/dasherize.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { helper } from '@ember/component/helper';
2+
import { dasherize as dasherizeString } from '@ember/string';
3+
4+
export default helper(function dasherize(positional /*, named*/) {
5+
return dasherizeString(positional[0]);
6+
});

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
},
2929
"devDependencies": {
3030
"@ember/optional-features": "^2.0.0",
31+
"@ember/string": "^4.0.1",
3132
"@ember/test-helpers": "^2.6.0",
3233
"@glimmer/component": "^1.0.4",
3334
"@glimmer/tracking": "^1.0.4",

pnpm-lock.yaml

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
import { module, test } from 'qunit';
2+
import { setupRenderingTest } from 'ember-qunit';
3+
import { render } from '@ember/test-helpers';
4+
import { hbs } from 'ember-cli-htmlbars';
5+
6+
module('Integration | Helper | dasherize', function (hooks) {
7+
setupRenderingTest(hooks);
8+
9+
/**
10+
* This doesn't need comprehensive tests for the output of the dasherzie function
11+
* since it's just using @ember/string under the hood. This is just a smoke test
12+
* to make sure it's hooked up correctly
13+
*/
14+
test('it renders', async function (assert) {
15+
this.set('inputValue', 'Something Awesome');
16+
17+
await render(hbs`{{dasherize this.inputValue}}`);
18+
19+
assert.dom(this.element).hasText('something-awesome');
20+
});
21+
});

0 commit comments

Comments
 (0)