Angle Bracket LinkTo not respecting whitespace formatting

[tylerturdenpants]

One of the tests from https://github.com/ember-codemods/ember-angle-brackets-codemod/

Before ember-template-recast (correct)

input: 
{{link-to
  'Users'
  'apps.app.users.segments.segment'
  'all-users'
  (query-params searchTerm=searchTerm)
}}

output: 
<LinkTo
  @route="apps.app.users.segments.segment"
  @model="all-users"
  @query={{hash searchTerm=searchTerm}}
>
  Users
</LinkTo>

After ember-template-recast refactor (incorrect)

input: 
{{link-to
  'Users'
  'apps.app.users.segments.segment'
  'all-users'
  (query-params searchTerm=searchTerm)
}}

output: 
<LinkTo @route="Users" @models={{array 'apps.app.users.segments.segment' 'all-users'}}>Users</LinkTo>

[rwjblue]

I'm not sure this is going to be something we can fix. As far as I understand what is going on, the ember-angle-bracket-invocation-codemod is creating a new ElementNode with new AttrNode's which means we have no original source information that we can use to determine what to do.

I think the best path forward is to provide an API for asking ember-template-recast for an existing nodes "whitespace separator" information and another API to set that info on the newly created node.

What do you think?

[tylerturdenpants]

As we discussed, an API would be great, but in the meantime rewriting the new LinkTo with no whitespace separator is fine. We can release an improvement to this scenario as soon as one becomes available

[rwjblue]

Sounds good, but I’ll keep this open in the meantime to track the broader api work that needs to happen.