Fix more lint

Author: RobbieTheWagner

app/components/date-property-field.ts

@@ -7,10 +7,11 @@ export default class DatePropertyFieldComponent extends DatePicker {
   onInsert(element: HTMLInputElement) {
     super.onInsert(element);
 
+    // eslint-disable-next-line ember/no-runloop
     scheduleOnce('afterRender', this, this._openFlatpickr);
   }
 
-  _openFlatpickr() {
+  _openFlatpickr = () => {
     this.flatpickrRef?.open();
-  }
+  };
 }

app/components/list.js

@@ -13,9 +13,6 @@ export default class ListComponent extends Component {
   /**
    * Layout service used to listen to changes to the application
    * layout such as resizing of the main nav or object inspector.
-   *
-   * @property layoutService
-   * @type {Service}
    */
   @service('layout') layoutService;
 
@@ -120,6 +117,7 @@ export default class ListComponent extends Component {
     let oldSchema = this.oldSchema;
     let newSchema = this.schema;
     if (newSchema && newSchema !== oldSchema) {
+      // eslint-disable-next-line ember/no-runloop
       scheduleOnce('actions', this, this.setupColumns);
     }
     this.oldSchema = newSchema;
@@ -128,6 +126,7 @@ export default class ListComponent extends Component {
   @action
   elementInserted(el) {
     this.el = el;
+    // eslint-disable-next-line ember/no-runloop
     scheduleOnce('afterRender', this, this.setupColumns);
     this.onResize = () => {
       this.debounceColumnWidths.perform();
@@ -157,6 +156,7 @@ export default class ListComponent extends Component {
         arr.push({
           name,
           title: name,
+          // eslint-disable-next-line ember/no-runloop
           fn: bind(this, this.toggleColumnVisibility, id),
         });
         return arr;

app/components/object-inspector/sort-properties.js

@@ -1,5 +1,7 @@
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { map, sort } from '@ember/object/computed';
 import Component from '@glimmer/component';
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { set, computed } from '@ember/object';
 import { A } from '@ember/array';
 

app/components/render-item.ts

@@ -1,10 +1,13 @@
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 import Component from '@glimmer/component';
 import { isEmpty } from '@ember/utils';
 import { htmlSafe } from '@ember/template';
 import escapeRegExp from 'ember-inspector/utils/escape-reg-exp';
 
 interface RenderItemArgs {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   list: any;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   model: any;
   search: string;
   target: { level: number };
@@ -34,7 +37,7 @@ export default class RenderItem extends Component<RenderItemArgs> {
   }
 
   get readableTime() {
-    const d = new Date(this.args.model?.timestamp);
+    const d = new Date(this.args.model?.timestamp as string);
     const ms = d.getMilliseconds();
     const seconds = d.getSeconds();
     const minutes =
@@ -52,7 +55,7 @@ export default class RenderItem extends Component<RenderItemArgs> {
     if (isEmpty(search)) {
       return true;
     }
-    const name = this.args.model?.name;
+    const name = this.args.model?.name as string;
     const regExp = new RegExp(escapeRegExp(search.toLowerCase()) as string);
     return !!name.toLowerCase().match(regExp);
   }

app/controllers/container-type.js

@@ -1,5 +1,6 @@
 import Controller, { inject as controller } from '@ember/controller';
 import { inject as service } from '@ember/service';
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { action, computed, set } from '@ember/object';
 import debounceComputed from 'ember-inspector/computed/debounce';
 import searchMatch from 'ember-inspector/utils/search-match';

app/controllers/container-types.js

@@ -1,15 +1,12 @@
+// eslint-disable-next-line ember/no-computed-properties-in-native-classes
 import { sort } from '@ember/object/computed';
 import { inject as service } from '@ember/service';
 import Controller from '@ember/controller';
 
 export default class ContainerTypesController extends Controller {
   @service router;
 
-  @sort('model', 'sortProperties') sorted;
-
-  constructor() {
-    super(...arguments);
+  sortProperties = ['name'];
 
-    this.sortProperties = ['name'];
-  }
+  @sort('model', 'sortProperties') sorted;
 }

app/services/adapters/web-extension.ts

@@ -71,19 +71,19 @@ export default class WebExtension extends BasicAdapter {
   }
 
   _handleReload() {
-    const self = this;
-    chrome.devtools.network.onNavigated.addListener(function () {
-      self._injectDebugger();
+    chrome.devtools.network.onNavigated.addListener(() => {
+      this._injectDebugger();
       location.reload();
     });
   }
 
   _injectDebugger() {
-    loadEmberDebug().then((emberDebug) => {
+    void loadEmberDebug().then((emberDebug) => {
       chrome.devtools.inspectedWindow.eval(
         emberDebug as string,
         (success, error) => {
           if (success === undefined && error) {
+            // eslint-disable-next-line @typescript-eslint/only-throw-error
             throw error;
           }
         },
@@ -131,7 +131,7 @@ export default class WebExtension extends BasicAdapter {
     scripts as soon as possible into the new page.
   */
   reloadTab() {
-    loadEmberDebug().then((emberDebug) => {
+    void loadEmberDebug().then((emberDebug) => {
       chrome.devtools.inspectedWindow.reload({
         injectedScript: emberDebug as string,
       });

ember_debug/libs/render-tree.js

@@ -13,7 +13,7 @@ class InElementSupportProvider {
     this.reference = this.require('@glimmer/reference');
     try {
       this.Wormhole = requireModule('ember-wormhole/components/ember-wormhole');
-    } catch (e) {
+    } catch {
       // nope
     }
 
@@ -22,7 +22,7 @@ class InElementSupportProvider {
         '@glimmer/manager',
       ).CustomModifierManager.prototype.getDebugInstance = (args) =>
         args.modifier || args.delegate;
-    } catch (e) {
+    } catch {
       // nope
     }
 
@@ -151,7 +151,7 @@ class InElementSupportProvider {
             if (!name) {
               try {
                 name = modifier.manager?.getDebugName?.();
-              } catch (e) {
+              } catch {
                 // failed
               }
               name = name || 'unknown-modifier';
@@ -175,12 +175,12 @@ class InElementSupportProvider {
             if (!self.reference.createUnboundRef) {
               try {
                 named = modifierState?.args?.named?.constructor;
-              } catch (e) {
+              } catch {
                 //
               }
               try {
                 named = named || modifierState?.args?.named?.map;
-              } catch (e) {
+              } catch {
                 //
               }
             }

ember_debug/utils/ember/loader.js

@@ -3,15 +3,15 @@ import Ember from '../ember';
 const require = function (id) {
   try {
     return Ember.__loader.require(id);
-  } catch (e) {
+  } catch {
     return requireModule(id);
   }
 };
 
 export function emberSafeRequire(id) {
   try {
     return require(id);
-  } catch (e) {
+  } catch {
     return undefined;
   }
 }

ember_debug/utils/type-check.js

@@ -91,7 +91,7 @@ export function inspect(value) {
     ) {
       try {
         return `<Object:${value.toString()}>`;
-      } catch (e) {
+      } catch {
         //
       }
     }

eslint.config.mjs

@@ -77,6 +77,7 @@ export default ts.config(
       reportUnusedDisableDirectives: 'error',
     },
   },
+  { rules: { 'no-prototype-builtins': 'off' } },
   {
     files: ['**/*.js'],
     languageOptions: {