Skip to content

Commit 5c19329

Browse files
authored
Merge pull request #20609 from NullVoxPopuli/upgrade-to-glimmer-vm-0-86
Bump all glimmer-vm dependencies to 0.87.1
2 parents 5ca3e86 + 1ea6c40 commit 5c19329

File tree

28 files changed

+454
-466
lines changed

28 files changed

+454
-466
lines changed

package.json

+16-16
Original file line numberDiff line numberDiff line change
@@ -58,24 +58,24 @@
5858
"dependencies": {
5959
"@babel/helper-module-imports": "^7.16.7",
6060
"@ember/edition-utils": "^1.2.0",
61-
"@glimmer/compiler": "0.85.13",
61+
"@glimmer/compiler": "0.87.1",
6262
"@glimmer/component": "^1.1.2",
63-
"@glimmer/destroyable": "0.85.13",
63+
"@glimmer/destroyable": "0.87.1",
6464
"@glimmer/env": "^0.1.7",
65-
"@glimmer/global-context": "0.85.13",
66-
"@glimmer/interfaces": "0.85.13",
67-
"@glimmer/manager": "0.85.13",
68-
"@glimmer/node": "0.85.13",
69-
"@glimmer/opcode-compiler": "0.85.13",
70-
"@glimmer/owner": "0.85.13",
71-
"@glimmer/program": "0.85.13",
72-
"@glimmer/reference": "0.85.13",
73-
"@glimmer/runtime": "0.85.13",
74-
"@glimmer/syntax": "0.85.13",
75-
"@glimmer/util": "0.85.13",
76-
"@glimmer/validator": "0.85.13",
77-
"@glimmer/vm": "0.85.13",
78-
"@glimmer/vm-babel-plugins": "0.85.13",
65+
"@glimmer/global-context": "0.87.1",
66+
"@glimmer/interfaces": "0.87.1",
67+
"@glimmer/manager": "0.87.1",
68+
"@glimmer/node": "0.87.1",
69+
"@glimmer/opcode-compiler": "0.87.1",
70+
"@glimmer/owner": "0.87.1",
71+
"@glimmer/program": "0.87.1",
72+
"@glimmer/reference": "0.87.1",
73+
"@glimmer/runtime": "0.87.1",
74+
"@glimmer/syntax": "0.87.1",
75+
"@glimmer/util": "0.87.1",
76+
"@glimmer/validator": "0.87.1",
77+
"@glimmer/vm": "0.87.1",
78+
"@glimmer/vm-babel-plugins": "0.87.1",
7979
"@simple-dom/interface": "^1.4.0",
8080
"babel-plugin-debug-macros": "^0.3.4",
8181
"babel-plugin-ember-template-compilation": "^2.1.1",

packages/@ember/-internals/glimmer/lib/utils/bindings.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ export function installAttributeBinding(
5858
let [prop, attribute, isSimple] = parsed;
5959

6060
if (attribute === 'id') {
61-
let elementId = get(component, prop);
61+
// SAFETY: `get` could not infer the type of `prop` and just gave us `unknown`.
62+
// we may want to throw an error in the future if the value isn't string or null/undefined.
63+
let elementId = get(component, prop) as string | null;
6264
if (elementId === undefined || elementId === null) {
6365
elementId = component.elementId;
6466
}

packages/@ember/-internals/glimmer/tests/integration/modifiers/on-test.js

-13
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { moduleFor, RenderingTestCase, runTask } from 'internal-test-helpers';
2-
import { isChrome, isFirefox } from '@ember/-internals/browser-environment';
32
import { getInternalModifierManager } from '@glimmer/manager';
43
import { on } from '@glimmer/runtime';
54

@@ -32,18 +31,6 @@ moduleFor(
3231
);
3332
}
3433

35-
'@test SUPPORTS_EVENT_OPTIONS is correct (private API usage)'(assert) {
36-
let manager = this.getOnManagerInstance();
37-
38-
let { SUPPORTS_EVENT_OPTIONS } = manager;
39-
40-
if (isChrome || isFirefox) {
41-
assert.strictEqual(SUPPORTS_EVENT_OPTIONS, true, 'is true in chrome and firefox');
42-
} else {
43-
assert.expect(0);
44-
}
45-
}
46-
4734
['@test it adds an event listener'](assert) {
4835
let count = 0;
4936

packages/@ember/-internals/package.json

+15-16
Original file line numberDiff line numberDiff line change
@@ -39,23 +39,23 @@
3939
"@ember/service": "workspace:*",
4040
"@ember/template-factory": "workspace:*",
4141
"@ember/utils": "workspace:*",
42-
"@glimmer/compiler": "0.85.13",
42+
"@glimmer/compiler": "0.87.1",
4343
"@glimmer/component": "^1.1.2",
44-
"@glimmer/destroyable": "0.85.13",
44+
"@glimmer/destroyable": "0.87.1",
4545
"@glimmer/env": "^0.1.7",
46-
"@glimmer/global-context": "0.85.13",
47-
"@glimmer/interfaces": "0.85.13",
48-
"@glimmer/manager": "0.85.13",
49-
"@glimmer/node": "0.85.13",
50-
"@glimmer/opcode-compiler": "0.85.13",
51-
"@glimmer/owner": "0.85.13",
52-
"@glimmer/program": "0.85.13",
53-
"@glimmer/reference": "0.85.13",
54-
"@glimmer/runtime": "0.85.13",
55-
"@glimmer/syntax": "0.85.13",
56-
"@glimmer/util": "0.85.13",
57-
"@glimmer/validator": "0.85.13",
58-
"@glimmer/vm": "0.85.13",
46+
"@glimmer/global-context": "0.87.1",
47+
"@glimmer/interfaces": "0.87.1",
48+
"@glimmer/manager": "0.87.1",
49+
"@glimmer/node": "0.87.1",
50+
"@glimmer/opcode-compiler": "0.87.1",
51+
"@glimmer/owner": "0.87.1",
52+
"@glimmer/program": "0.87.1",
53+
"@glimmer/reference": "0.87.1",
54+
"@glimmer/runtime": "0.87.1",
55+
"@glimmer/syntax": "0.87.1",
56+
"@glimmer/util": "0.87.1",
57+
"@glimmer/validator": "0.87.1",
58+
"@glimmer/vm": "0.87.1",
5959
"@simple-dom/interface": "^1.4.0",
6060
"backburner.js": "^2.7.0",
6161
"dag-map": "^2.0.2",
@@ -67,4 +67,3 @@
6767
"rsvp": "^4.8.5"
6868
}
6969
}
70-

packages/@ember/application/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919
"@ember/runloop": "workspace:*",
2020
"@ember/service": "workspace:*",
2121
"@ember/utils": "workspace:*",
22-
"@glimmer/destroyable": "0.85.13",
22+
"@glimmer/destroyable": "0.87.1",
2323
"@glimmer/env": "^0.1.7",
24-
"@glimmer/owner": "0.85.13",
25-
"@glimmer/util": "0.85.13",
26-
"@glimmer/validator": "0.85.13",
24+
"@glimmer/owner": "0.87.1",
25+
"@glimmer/util": "0.87.1",
26+
"@glimmer/validator": "0.87.1",
2727
"backburner.js": "^2.7.0",
2828
"dag-map": "^2.0.2",
2929
"ember": "workspace:*",

packages/@ember/array/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
"@ember/object": "workspace:*",
1717
"@ember/runloop": "workspace:*",
1818
"@ember/utils": "workspace:*",
19-
"@glimmer/destroyable": "0.85.13",
19+
"@glimmer/destroyable": "0.87.1",
2020
"@glimmer/env": "^0.1.7",
21-
"@glimmer/manager": "0.85.13",
22-
"@glimmer/owner": "0.85.13",
23-
"@glimmer/util": "0.85.13",
24-
"@glimmer/validator": "0.85.13",
21+
"@glimmer/manager": "0.87.1",
22+
"@glimmer/owner": "0.87.1",
23+
"@glimmer/util": "0.87.1",
24+
"@glimmer/validator": "0.87.1",
2525
"expect-type": "^0.15.0",
2626
"internal-test-helpers": "workspace:*"
2727
}

packages/@ember/component/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
},
1010
"dependencies": {
1111
"@ember/-internals": "workspace:*",
12-
"@glimmer/manager": "0.85.13",
13-
"@glimmer/runtime": "0.85.13",
12+
"@glimmer/manager": "0.87.1",
13+
"@glimmer/runtime": "0.87.1",
1414
"expect-type": "^0.15.0"
1515
}
1616
}

packages/@ember/controller/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
"@ember/debug": "workspace:*",
1212
"@ember/object": "workspace:*",
1313
"@ember/service": "workspace:*",
14-
"@glimmer/destroyable": "0.85.13",
14+
"@glimmer/destroyable": "0.87.1",
1515
"@glimmer/env": "^0.1.7",
16-
"@glimmer/owner": "0.85.13",
17-
"@glimmer/util": "0.85.13",
18-
"@glimmer/validator": "0.85.13",
16+
"@glimmer/owner": "0.87.1",
17+
"@glimmer/util": "0.87.1",
18+
"@glimmer/validator": "0.87.1",
1919
"expect-type": "^0.15.0",
2020
"internal-test-helpers": "workspace:*"
2121
}

packages/@ember/debug/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818
"@ember/routing": "workspace:*",
1919
"@ember/runloop": "workspace:*",
2020
"@ember/utils": "workspace:*",
21-
"@glimmer/destroyable": "0.85.13",
21+
"@glimmer/destroyable": "0.87.1",
2222
"@glimmer/env": "^0.1.7",
23-
"@glimmer/manager": "0.85.13",
24-
"@glimmer/owner": "0.85.13",
25-
"@glimmer/util": "0.85.13",
26-
"@glimmer/validator": "0.85.13",
23+
"@glimmer/manager": "0.87.1",
24+
"@glimmer/owner": "0.87.1",
25+
"@glimmer/util": "0.87.1",
26+
"@glimmer/validator": "0.87.1",
2727
"backburner.js": "^2.7.0",
2828
"expect-type": "^0.15.0",
2929
"internal-test-helpers": "workspace:*"

packages/@ember/destroyable/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
".": "./index.ts"
77
},
88
"dependencies": {
9-
"@glimmer/destroyable": "0.85.13",
9+
"@glimmer/destroyable": "0.87.1",
1010
"expect-type": "^0.15.0"
1111
}
1212
}

packages/@ember/engine/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
"@ember/runloop": "workspace:*",
1919
"@ember/service": "workspace:*",
2020
"@ember/utils": "workspace:*",
21-
"@glimmer/destroyable": "0.85.13",
21+
"@glimmer/destroyable": "0.87.1",
2222
"@glimmer/env": "^0.1.7",
23-
"@glimmer/owner": "0.85.13",
24-
"@glimmer/util": "0.85.13",
25-
"@glimmer/validator": "0.85.13",
23+
"@glimmer/owner": "0.87.1",
24+
"@glimmer/util": "0.87.1",
25+
"@glimmer/validator": "0.87.1",
2626
"dag-map": "^2.0.2",
2727
"expect-type": "^0.15.0",
2828
"internal-test-helpers": "workspace:*",

packages/@ember/enumerable/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
"@ember/array": "workspace:*",
1212
"@ember/debug": "workspace:*",
1313
"@ember/object": "workspace:*",
14-
"@glimmer/destroyable": "0.85.13",
14+
"@glimmer/destroyable": "0.87.1",
1515
"@glimmer/env": "^0.1.7",
16-
"@glimmer/owner": "0.85.13",
17-
"@glimmer/util": "0.85.13",
18-
"@glimmer/validator": "0.85.13",
16+
"@glimmer/owner": "0.87.1",
17+
"@glimmer/util": "0.87.1",
18+
"@glimmer/validator": "0.87.1",
1919
"internal-test-helpers": "workspace:*"
2020
}
2121
}

packages/@ember/helper/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"dependencies": {
99
"@ember/-internals": "workspace:*",
1010
"@ember/component": "workspace:*",
11-
"@glimmer/manager": "0.85.13",
12-
"@glimmer/runtime": "0.85.13",
11+
"@glimmer/manager": "0.87.1",
12+
"@glimmer/runtime": "0.87.1",
1313
"expect-type": "^0.15.0"
1414
}
1515
}

packages/@ember/instrumentation/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"@ember/runloop": "workspace:*",
1515
"@ember/utils": "workspace:*",
1616
"@glimmer/env": "^0.1.7",
17-
"@glimmer/validator": "0.85.13",
17+
"@glimmer/validator": "0.87.1",
1818
"internal-test-helpers": "workspace:*"
1919
}
2020
}

packages/@ember/modifier/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
},
88
"dependencies": {
99
"@ember/-internals": "workspace:*",
10-
"@glimmer/manager": "0.85.13",
11-
"@glimmer/runtime": "0.85.13"
10+
"@glimmer/manager": "0.87.1",
11+
"@glimmer/runtime": "0.87.1"
1212
}
1313
}

packages/@ember/object/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@
2626
"@ember/runloop": "workspace:*",
2727
"@ember/service": "workspace:*",
2828
"@ember/utils": "workspace:*",
29-
"@glimmer/destroyable": "0.85.13",
29+
"@glimmer/destroyable": "0.87.1",
3030
"@glimmer/env": "^0.1.7",
31-
"@glimmer/manager": "0.85.13",
32-
"@glimmer/owner": "0.85.13",
33-
"@glimmer/util": "0.85.13",
34-
"@glimmer/validator": "0.85.13",
31+
"@glimmer/manager": "0.87.1",
32+
"@glimmer/owner": "0.87.1",
33+
"@glimmer/util": "0.87.1",
34+
"@glimmer/validator": "0.87.1",
3535
"expect-type": "^0.15.0",
3636
"internal-test-helpers": "workspace:*"
3737
}

packages/@ember/routing/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
"@ember/runloop": "workspace:*",
2626
"@ember/service": "workspace:*",
2727
"@ember/utils": "workspace:*",
28-
"@glimmer/destroyable": "0.85.13",
28+
"@glimmer/destroyable": "0.87.1",
2929
"@glimmer/env": "^0.1.7",
30-
"@glimmer/manager": "0.85.13",
31-
"@glimmer/owner": "0.85.13",
32-
"@glimmer/util": "0.85.13",
33-
"@glimmer/validator": "0.85.13",
30+
"@glimmer/manager": "0.87.1",
31+
"@glimmer/owner": "0.87.1",
32+
"@glimmer/util": "0.87.1",
33+
"@glimmer/validator": "0.87.1",
3434
"backburner.js": "^2.7.0",
3535
"dag-map": "^2.0.2",
3636
"expect-type": "^0.15.0",

packages/@ember/runloop/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@ember/object": "workspace:*",
1414
"@ember/utils": "workspace:*",
1515
"@glimmer/env": "^0.1.7",
16-
"@glimmer/validator": "0.85.13",
16+
"@glimmer/validator": "0.87.1",
1717
"backburner.js": "^2.7.0",
1818
"expect-type": "^0.15.0",
1919
"internal-test-helpers": "workspace:*"

packages/@ember/service/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"@ember/array": "workspace:*",
1111
"@ember/debug": "workspace:*",
1212
"@ember/object": "workspace:*",
13-
"@glimmer/destroyable": "0.85.13",
13+
"@glimmer/destroyable": "0.87.1",
1414
"@glimmer/env": "^0.1.7",
15-
"@glimmer/owner": "0.85.13",
16-
"@glimmer/util": "0.85.13",
17-
"@glimmer/validator": "0.85.13",
15+
"@glimmer/owner": "0.87.1",
16+
"@glimmer/util": "0.87.1",
17+
"@glimmer/validator": "0.87.1",
1818
"expect-type": "^0.15.0",
1919
"internal-test-helpers": "workspace:*"
2020
}

packages/@ember/template-compilation/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
"dependencies": {
99
"@ember/-internals": "workspace:*",
1010
"@ember/canary-features": "workspace:*",
11-
"@glimmer/compiler": "0.85.13",
11+
"@glimmer/compiler": "0.87.1",
1212
"@glimmer/env": "^0.1.7",
13-
"@glimmer/syntax": "0.85.13",
13+
"@glimmer/syntax": "0.87.1",
1414
"ember": "workspace:*",
1515
"ember-template-compiler": "workspace:*"
1616
}

packages/@ember/template-factory/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
".": "./index.ts"
77
},
88
"dependencies": {
9-
"@glimmer/opcode-compiler": "0.85.13"
9+
"@glimmer/opcode-compiler": "0.87.1"
1010
}
1111
}

packages/@ember/utils/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@
1313
"@ember/enumerable": "workspace:*",
1414
"@ember/object": "workspace:*",
1515
"@ember/runloop": "workspace:*",
16-
"@glimmer/destroyable": "0.85.13",
16+
"@glimmer/destroyable": "0.87.1",
1717
"@glimmer/env": "^0.1.7",
18-
"@glimmer/manager": "0.85.13",
19-
"@glimmer/owner": "0.85.13",
20-
"@glimmer/util": "0.85.13",
21-
"@glimmer/validator": "0.85.13",
18+
"@glimmer/manager": "0.87.1",
19+
"@glimmer/owner": "0.87.1",
20+
"@glimmer/util": "0.87.1",
21+
"@glimmer/validator": "0.87.1",
2222
"expect-type": "^0.15.0",
2323
"internal-test-helpers": "workspace:*"
2424
}

packages/@ember/version/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"@ember/runloop": "workspace:*",
2323
"@ember/service": "workspace:*",
2424
"@ember/utils": "workspace:*",
25-
"@glimmer/manager": "0.85.13",
26-
"@glimmer/runtime": "0.85.13",
25+
"@glimmer/manager": "0.87.1",
26+
"@glimmer/runtime": "0.87.1",
2727
"backburner.js": "^2.7.0",
2828
"ember": "workspace:*",
2929
"expect-type": "^0.15.0"

packages/ember-template-compiler/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424
"@ember/service": "workspace:*",
2525
"@ember/template-compilation": "workspace:*",
2626
"@ember/utils": "workspace:*",
27-
"@glimmer/compiler": "0.85.13",
27+
"@glimmer/compiler": "0.87.1",
2828
"@glimmer/env": "^0.1.7",
29-
"@glimmer/manager": "0.85.13",
30-
"@glimmer/runtime": "0.85.13",
31-
"@glimmer/syntax": "0.85.13",
32-
"@glimmer/validator": "0.85.13",
29+
"@glimmer/manager": "0.87.1",
30+
"@glimmer/runtime": "0.87.1",
31+
"@glimmer/syntax": "0.87.1",
32+
"@glimmer/validator": "0.87.1",
3333
"backburner.js": "^2.7.0",
3434
"ember": "workspace:*",
3535
"internal-test-helpers": "workspace:*"

0 commit comments

Comments
 (0)