-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Description
In ember-auto-import's test suite, we have several tests that combine fastboot and ember-canary that crash during the destroy()
phase after successfully rendering a fastboot response.
This seems to have started since #20974. I patched out that one change and it makes the bug go away.
The crash happens because @ember/component
has willDestroy
logic that looks up an injected renderer
, and that logic is now running after the Container has already been destroyed, thus hitting the assertion against doing lookups on a destroyed container.
When the crash happens, the ApplicationInstance
has isDestroying===true && isDestroyed==false
, but the Container
that backs the ApplicationInstance
is already isDestroyed==true
.
No crash happens in the browser tests. Those initialize destruction from a different place than fastboot does though, which may explain the difference.