fix: use undefined to check for backgroundReload option (#80)

Author: samselikoff

addon/mixins/loadable-store.js

@@ -56,7 +56,7 @@ export default Mixin.create({
   loadRecords(type, options={}) {
     let query = this.coordinator.recordArrayQueryFor(type, options);
     let shouldBlock = options.reload || !query.value;
-    let shouldBackgroundReload = !options.hasOwnProperty('backgroundReload') || options.backgroundReload;
+    let shouldBackgroundReload = (options.backgroundReload !== undefined) ? options.backgroundReload : true;
     let promise;
     let fetcher;
 
@@ -126,7 +126,7 @@ export default Mixin.create({
   loadRecord(type, id, options={}) {
     let query = this.coordinator.recordQueryFor(type, id, options);
     let shouldBlock = options.reload || !query.value;
-    let shouldBackgroundReload = !options.hasOwnProperty('backgroundReload') || options.backgroundReload;
+    let shouldBackgroundReload = (options.backgroundReload !== undefined) ? options.backgroundReload : true;
     let promise;
 
     if (shouldBlock) {

tests/integration/components/load-records-example-test.js

@@ -0,0 +1,42 @@
+import { module, test } from 'qunit';
+import { setupRenderingTest } from 'ember-qunit';
+import Component from '@ember/component';
+import hbs from 'htmlbars-inline-precompile';
+import { inject as service } from '@ember/service';
+import { render } from '@ember/test-helpers';
+import Model from 'ember-data/model';
+import { startMirage } from 'dummy/initializers/ember-cli-mirage';
+
+module('Integration | Component | Load records example', function(hooks) {
+  setupRenderingTest(hooks);
+
+  hooks.beforeEach(function() {
+    this.owner.register('model:user', Model.extend());
+    this.owner.register('component:load-records', Component.extend({
+      store: service(),
+      didInsertElement() {
+        this._super(...arguments);
+
+        this.get('store').loadRecords(this.modelName, { ...this.params });
+      }
+    }));
+    this.server = startMirage();
+  });
+
+  // This ensures users can write a <LoadRecords /> component. See https://github.com/embermap/ember-data-storefront/issues/79.
+  test('users should be able to invoke #loadRecords using a hash from a template', async function(assert) {
+    this.server.get('/users', () => ({ data: []}));
+
+    await render(hbs`
+      {{load-records
+        modelName='user'
+        params=(hash
+          sort='-position'
+          page=(hash limit=4)
+        )
+      }}
+    `);
+
+    assert.ok(true);
+  });
+});