Create a cap for the size of collected stacktraces (#2252)

## Goal

There's no ceiling to the size of stacktraces we collect. Making sure we don't get more than 500, even through in practice, we should be getting no more than what is specified in the remote config, which we control (or 200 if not specified).

There was one place we get stacktraces without limits - in the crash logs. We limit that to 200 now as well (and not configurable).

Author: bidetofevil

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/config/behavior/AnrBehaviorImpl.kt

@@ -2,6 +2,7 @@ package io.embrace.android.embracesdk.internal.config.behavior
 
 import io.embrace.android.embracesdk.internal.config.instrumented.schema.InstrumentedConfig
 import io.embrace.android.embracesdk.internal.config.remote.RemoteConfig
+import io.embrace.android.embracesdk.internal.utils.DEFAULT_STACKTRACE_SIZE_LIMIT
 
 /**
  * Provides the behavior that the ANR feature should follow.
@@ -16,7 +17,7 @@ class AnrBehaviorImpl(
         private const val DEFAULT_ANR_PCT_ENABLED = true
         private const val DEFAULT_ANR_INTERVAL_MS: Long = 100
         private const val DEFAULT_ANR_MAX_PER_INTERVAL = 80
-        private const val DEFAULT_STACKTRACE_FRAME_LIMIT = 200
+        private const val DEFAULT_STACKTRACE_FRAME_LIMIT = DEFAULT_STACKTRACE_SIZE_LIMIT
         private const val DEFAULT_ANR_MAX_ANR_INTERVALS_PER_SESSION = 5
         private const val DEFAULT_ANR_MIN_CAPTURE_DURATION = 1000
     }

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/utils/ThreadExt.kt

@@ -2,16 +2,19 @@ package io.embrace.android.embracesdk.internal.utils
 
 import android.os.Build
 import io.embrace.android.embracesdk.internal.payload.ThreadInfo
+import kotlin.math.min
+
+const val DEFAULT_STACKTRACE_SIZE_LIMIT = 200
 
 fun getThreadInfo(
     thread: Thread,
     stackTraceElements: Array<StackTraceElement>,
-    maxStacktraceSize: Int = Integer.MAX_VALUE,
+    maxStacktraceSize: Int = DEFAULT_STACKTRACE_SIZE_LIMIT,
 ): ThreadInfo {
     val name = thread.name
     val priority = thread.priority
     val frameCount = stackTraceElements.size
-    val lines = stackTraceElements.take(maxStacktraceSize).map(StackTraceElement::toString)
+    val lines = stackTraceElements.take(min(MAX_STACKTRACE_SIZE, maxStacktraceSize)).map(StackTraceElement::toString)
     return ThreadInfo(thread.compatThreadId(), thread.state, name, priority, lines, frameCount)
 }
 
@@ -21,3 +24,5 @@ fun Thread.compatThreadId() = if (BuildVersionChecker.isAtLeast(Build.VERSION_CO
 } else {
     id
 }
+
+private const val MAX_STACKTRACE_SIZE = 500

embrace-android-core/src/test/java/io/embrace/android/embracesdk/internal/utils/ThreadExtKtTest.kt

@@ -10,6 +10,10 @@ import java.lang.Thread.currentThread
 @RunWith(AndroidJUnit4::class)
 class ThreadExtKtTest {
 
+    private val fakeBigStackTrace = Array(700) {
+        StackTraceElement("a", "b", "c", 1)
+    }
+
     @Test
     fun `correct threadInfo created`() {
         val targetThread = currentThread()
@@ -27,6 +31,25 @@ class ThreadExtKtTest {
         }
     }
 
+    @Test
+    fun `verify default stacktrace size is 200`() {
+        val threadInfo = getThreadInfo(
+            thread = currentThread(),
+            stackTraceElements = fakeBigStackTrace
+        )
+        assertEquals(200, threadInfo.lines?.size)
+    }
+
+    @Test
+    fun `verify max stacktrace size capped at 500`() {
+        val threadInfo = getThreadInfo(
+            thread = currentThread(),
+            stackTraceElements = fakeBigStackTrace,
+            maxStacktraceSize = 600
+        )
+        assertEquals(500, threadInfo.lines?.size)
+    }
+
     @Test
     fun `valid threadId retrieved`() {
         assertTrue(currentThread().compatThreadId() > 0)

embrace-test-fakes/src/main/kotlin/io/embrace/android/embracesdk/fakes/behavior/FakeAnrBehavior.kt

@@ -3,13 +3,14 @@ package io.embrace.android.embracesdk.fakes.behavior
 import io.embrace.android.embracesdk.internal.config.behavior.AnrBehavior
 import io.embrace.android.embracesdk.internal.config.instrumented.schema.EnabledFeatureConfig
 import io.embrace.android.embracesdk.internal.config.remote.AnrRemoteConfig
+import io.embrace.android.embracesdk.internal.utils.DEFAULT_STACKTRACE_SIZE_LIMIT
 
 class FakeAnrBehavior(
     var anrCaptureEnabled: Boolean = true,
     var bgAnrCaptureEnabled: Boolean = false,
     var sampleIntervalMsImpl: Long = 5,
     var anrPerSessionImpl: Int = 5,
-    var frameLimit: Int = 200,
+    var frameLimit: Int = DEFAULT_STACKTRACE_SIZE_LIMIT,
 ) : AnrBehavior {
 
     override val local: EnabledFeatureConfig