Skip to content

Commit 4c4cecd

Browse files
committed
Check to see if error conforms to a blocking exception
1 parent c1788bc commit 4c4cecd

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

embrace-android-delivery/src/main/kotlin/io/embrace/android/embracesdk/internal/delivery/scheduling/SchedulingServiceImpl.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ class SchedulingServiceImpl(
301301
}
302302

303303
private fun ExecutionResult.failedToConnect(): Boolean =
304-
this is ExecutionResult.Incomplete && (connectionBlockingExceptions.contains(exception.javaClass))
304+
this is ExecutionResult.Incomplete && (connectionBlockingExceptions.any { it.isInstance(exception) })
305305

306306
private fun ExecutionResult.connectedToServer(): Boolean =
307307
this !is ExecutionResult.NetworkNotReady && this !is ExecutionResult.NotAttempted

embrace-android-delivery/src/test/kotlin/io/embrace/android/embracesdk/internal/delivery/scheduling/SchedulingServiceImplTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ import org.junit.Before
3333
import org.junit.Test
3434
import java.net.ConnectException
3535
import java.net.SocketTimeoutException
36-
import java.net.UnknownHostException
3736
import java.util.concurrent.RejectedExecutionException
37+
import javax.net.ssl.SSLKeyException
3838

3939
internal class SchedulingServiceImplTest {
4040

@@ -789,7 +789,7 @@ internal class SchedulingServiceImplTest {
789789

790790
private fun disconnect() = setExecutionResult(Incomplete(ConnectException(), true))
791791

792-
private fun blockConnection() = setExecutionResult(Incomplete(UnknownHostException(), true))
792+
private fun blockConnection() = setExecutionResult(Incomplete(SSLKeyException("dang bad key"), true))
793793

794794
private fun setExecutionResult(result: ExecutionResult) {
795795
executionService.constantResponse = result

0 commit comments

Comments
 (0)