Skip to content

Commit a98a1ac

Browse files
committed
refactor: use otel-kotlin id
1 parent 0da6382 commit a98a1ac

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/payload/SpanMapper.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import io.embrace.android.embracesdk.internal.payload.Span
1111
import io.embrace.android.embracesdk.internal.payload.SpanEvent
1212
import io.embrace.android.embracesdk.spans.EmbraceSpanEvent
1313
import io.embrace.opentelemetry.kotlin.ExperimentalApi
14-
import io.embrace.opentelemetry.kotlin.aliases.OtelJavaSpanId
1514
import io.embrace.opentelemetry.kotlin.tracing.StatusCode
1615

1716
fun EmbraceSpanData.toEmbracePayload(): Span = Span(
@@ -57,7 +56,7 @@ fun Span.toEmbracePayload(): EmbraceSpanData {
5756
return EmbraceSpanData(
5857
traceId = traceId ?: "",
5958
spanId = spanId ?: "",
60-
parentSpanId = parentSpanId ?: OtelJavaSpanId.getInvalid(),
59+
parentSpanId = parentSpanId ?: OtelIds.invalidSpanId,
6160
name = name ?: "",
6261
startTimeNanos = startTimeNanos ?: 0,
6362
endTimeNanos = endTimeNanos ?: 0L,

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/sdk/id/OtelIds.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
package io.embrace.android.embracesdk.internal.otel.sdk.id
22

33
import io.embrace.opentelemetry.kotlin.aliases.OtelJavaIdGenerator
4-
import io.embrace.opentelemetry.kotlin.aliases.OtelJavaSpanId
4+
import io.embrace.opentelemetry.kotlin.k2j.id.TracingIdGeneratorImpl
55

66
object OtelIds {
77

8-
private val generator = OtelJavaIdGenerator.random()
8+
private val generator = TracingIdGeneratorImpl(OtelJavaIdGenerator.random())
99

1010
/**
1111
* Generates a new valid SpanId.
@@ -20,5 +20,5 @@ object OtelIds {
2020
/**
2121
* An invalid SpanId.
2222
*/
23-
val invalidSpanId: String = OtelJavaSpanId.getInvalid()
23+
val invalidSpanId: String = generator.invalidSpanId
2424
}

embrace-android-otel/src/test/kotlin/io/embrace/android/embracesdk/internal/otel/payload/SpanMapperTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ import io.embrace.android.embracesdk.internal.clock.nanosToMillis
1010
import io.embrace.android.embracesdk.internal.otel.schema.AppTerminationCause
1111
import io.embrace.android.embracesdk.internal.otel.schema.EmbType
1212
import io.embrace.android.embracesdk.internal.otel.schema.ErrorCodeAttribute
13+
import io.embrace.android.embracesdk.internal.otel.sdk.id.OtelIds
1314
import io.embrace.android.embracesdk.internal.otel.sdk.setEmbraceAttribute
1415
import io.embrace.android.embracesdk.internal.otel.sdk.toEmbraceSpanData
1516
import io.embrace.android.embracesdk.internal.otel.spans.hasEmbraceAttribute
1617
import io.embrace.android.embracesdk.internal.payload.Attribute
1718
import io.embrace.android.embracesdk.internal.payload.Span
1819
import io.embrace.android.embracesdk.spans.ErrorCode
19-
import io.embrace.opentelemetry.kotlin.aliases.OtelJavaSpanId
2020
import io.embrace.opentelemetry.kotlin.k2j.tracing.convertToOtelJava
2121
import org.junit.Assert.assertEquals
2222
import org.junit.Test
@@ -83,7 +83,7 @@ internal class SpanMapperTest {
8383

8484
return copy(
8585
endTimeNanos = endTimeMs.millisToNanos(),
86-
parentSpanId = parentSpanId ?: OtelJavaSpanId.getInvalid(),
86+
parentSpanId = parentSpanId ?: OtelIds.invalidSpanId,
8787
status = Span.Status.ERROR,
8888
attributes = newAttributes.map { Attribute(it.key, it.value) }.plus(attributes ?: emptyList())
8989
)

0 commit comments

Comments
 (0)