Remove Unity related code from the NDK upload tasks (#2209)

* Remove Unity related code from the NDK upload tasks

* Remove unnecessary mustRunAfter from NdkUploadTasksRegistration

* Move customSymbolsDirectory to EmbraceExtension

Author: priettt

embrace-gradle-plugin-integration-tests/src/test/java/io/embrace/android/gradle/integration/testcases/AndroidNdkTest.kt

@@ -100,9 +100,8 @@ class AndroidNdkTest {
         )
     }
 
-    // When a 3rd party dependency has native libraries, but the project has no externalNativeBuild block, we don't send symbols (yet).
     @Test
-    fun `don't send 3rd party native library symbols when the project has no native libraries`() {
+    fun `send 3rd party native library symbols even when the project has no native libraries`() {
         rule.runTest(
             fixture = "android-3rd-party-symbols",
             task = "build",
@@ -116,8 +115,8 @@ class AndroidNdkTest {
             },
             assertions = {
                 verifyBuildTelemetryRequestSent(defaultExpectedVariants)
-                verifyNoHandshakes()
-                verifyNoUploads()
+                verifyHandshakes(defaultExpectedLibs, defaultExpectedArchs, defaultExpectedVariants)
+                verifyUploads(defaultExpectedLibs, defaultExpectedArchs, defaultExpectedVariants)
             }
         )
     }

embrace-gradle-plugin-integration-tests/src/test/java/io/embrace/android/gradle/integration/testcases/ConfigInstrumentationTest.kt

@@ -56,6 +56,12 @@ class ConfigInstrumentationTest {
                 File(projectDir, "src/main/embrace-config.json").outputStream().buffered().use {
                     ResourceReader.readResource("config-overrides.json").buffered().copyTo(it)
                 }
+                // TODO: why is libembrace-native uploaded in this fixture, but not in the rest?
+                setupMockResponses(
+                    expectedLibs = listOf("libembrace-native.so"),
+                    expectedArchs = listOf("x86_64", "x86", "armeabi-v7a", "arm64-v8a"),
+                    expectedVariants = listOf("debug", "release")
+                )
             },
             assertions = { projectDir ->
                 verifyInstrumentedConfig(projectDir, "instrumented-config-overrides.json")

embrace-gradle-plugin/src/main/java/io/embrace/android/gradle/plugin/EmbraceGradlePluginDelegate.kt

@@ -52,8 +52,7 @@ class EmbraceGradlePluginDelegate {
             project,
             behavior,
             embraceVariantConfigurationBuilder,
-            variantConfigurationsListProperty,
-            agpWrapper
+            variantConfigurationsListProperty
         )
 
         taskRegistrar.registerTasks()

embrace-gradle-plugin/src/main/java/io/embrace/android/gradle/plugin/api/EmbraceExtension.kt

@@ -35,6 +35,12 @@ abstract class EmbraceExtension @Inject internal constructor(objectFactory: Obje
      */
     val failBuildOnUploadErrors: Property<Boolean> = objectFactory.property(Boolean::class.java).convention(true)
 
+    /**
+     * A custom directory that, if set, should contain architecture directories (arm64-v8a/, etc.) with shared object files (.so files).
+     * This directory will be used to upload the shared object files to Embrace, and use them for crash symbolication.
+     */
+    val customSymbolsDirectory: Property<String> = objectFactory.property(String::class.java)
+
     /**
      * DSL for configuring how Embrace instruments bytecode.
      */

embrace-gradle-plugin/src/main/java/io/embrace/android/gradle/plugin/config/PluginBehavior.kt

@@ -57,7 +57,7 @@ interface PluginBehavior {
     val autoAddEmbraceComposeDependency: Boolean
 
     /**
-     * A custom directory containing SO files, set via `swazzler.customSymbolsDirectory`
+     * A custom directory containing SO files, set via `embrace.customSymbolsDirectory`
      */
     val customSymbolsDirectory: String?
 

embrace-gradle-plugin/src/main/java/io/embrace/android/gradle/plugin/config/PluginBehaviorImpl.kt

@@ -73,7 +73,7 @@ class PluginBehaviorImpl(
     }
 
     override val customSymbolsDirectory: String? by lazy {
-        extension.customSymbolsDirectory.orNull
+        embrace.customSymbolsDirectory.orNull ?: extension.customSymbolsDirectory.orNull
     }
 
     override fun isInstrumentationDisabledForVariant(variantName: String): Boolean {