Gradle warnings about Embrace Plugin using deprecated features / syntax

[jt-gilkeson]

embrace = 7.4.0

We use the following declaration (from the embrace documentation) in our build.gradle:

    embrace {
        buildVariantFilter {
            if (it.name.contains("debug")) {
                it.disablePluginForVariant()
                it.disableBytecodeInstrumentationForVariant()
            }
        }
    }

The latest gradle complains about the embrace plugin and the syntax of the build variant filter:
StartParameter.isConfigurationCacheRequested property has been deprecated (used in the embrace plugin)

io.embrace.swazzler
- [warn] The StartParameter.isConfigurationCacheRequested property has been deprecated.io.embrace.swazzler
This is scheduled to be removed in Gradle 10.0.
The StartParameter.isConfigurationCacheRequested property has been deprecated.
- Solutions: Please use 'configurationCache.requested' property on 'BuildFeatures' service instead.

and

Properties should be assigned using the 'propName = value' syntax. (buildVariantFilter )

The StartParameter.isConfigurationCacheRequested property has been deprecated. This is scheduled to be removed in Gradle 10.0. Please use 'configurationCache.requested' property on 'BuildFeatures' service instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.14/userguide/upgrading_version_8.html#deprecated_startparameter_is_configuration_cache_requested
	at org.gradle.internal.deprecation.StartParameterDeprecations.nagOnIsConfigurationCacheRequested(StartParameterDeprecations.java:28)
	at org.gradle.api.internal.StartParameterInternal.isConfigurationCacheRequested(StartParameterInternal.java:160)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryCollector.isConfigurationCacheEnabled(BuildTelemetryCollector.kt:85)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryCollector.collect(BuildTelemetryCollector.kt:38)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryService$Companion$register$serviceProvider$1$1.invoke(BuildTelemetryService.kt:60)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryService$Companion$register$serviceProvider$1$1.invoke(BuildTelemetryService.kt:59)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryService$Companion$register$serviceProvider$1.invoke$lambda$0(BuildTelemetryService.kt:59)
	at org.gradle.api.services.internal.DefaultBuildServicesRegistry$DefaultServiceSpec.parameters(DefaultBuildServicesRegistry.java:382)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryService$Companion$register$serviceProvider$1.invoke(BuildTelemetryService.kt:59)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryService$Companion$register$serviceProvider$1.invoke(BuildTelemetryService.kt:55)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryService$Companion.register$lambda$0(BuildTelemetryService.kt:58)
	at org.gradle.api.services.internal.DefaultBuildServicesRegistry.lambda$registerIfAbsent$4(DefaultBuildServicesRegistry.java:173)
	at org.gradle.api.services.internal.DefaultBuildServicesRegistry.lambda$doRegisterIfAbsent$6(DefaultBuildServicesRegistry.java:198)
	at org.gradle.api.services.internal.DefaultBuildServicesRegistry.withRegistrations(DefaultBuildServicesRegistry.java:103)
	at org.gradle.api.services.internal.DefaultBuildServicesRegistry.doRegisterIfAbsent(DefaultBuildServicesRegistry.java:189)
	at org.gradle.api.services.internal.DefaultBuildServicesRegistry.registerIfAbsent(DefaultBuildServicesRegistry.java:167)
	at io.embrace.android.gradle.plugin.buildreporter.BuildTelemetryService$Companion.register(BuildTelemetryService.kt:55)
	at io.embrace.android.gradle.plugin.EmbraceGradlePluginDelegate.onAndroidPluginApplied(EmbraceGradlePluginDelegate.kt:38)
	at io.embrace.android.gradle.plugin.EmbraceGradlePlugin$apply$1.invoke(EmbraceGradlePlugin.kt:48)
	at io.embrace.android.gradle.plugin.EmbraceGradlePlugin$apply$1.invoke(EmbraceGradlePlugin.kt:47)
	at io.embrace.android.gradle.plugin.EmbraceGradlePlugin.apply$lambda$0(EmbraceGradlePlugin.kt:47)
	at org.gradle.api.internal.plugins.DefaultPluginManager$2.execute(DefaultPluginManager.java:261)
	at org.gradle.api.internal.plugins.DefaultPluginManager$2.execute(DefaultPluginManager.java:258)
...
	at Build file 'C:\Code\appname\app\build.gradle': line 186
Properties should be assigned using the 'propName = value' syntax. Setting a property via the Gradle-generated 'propName value' or 'propName(value)' syntax in Groovy DSL has been deprecated. This is scheduled to be removed in Gradle 10.0. Use assignment ('buildVariantFilter = <value>') instead. Consult the upgrading guide for further information: https://docs.gradle.org/8.14/userguide/upgrading_version_8.html#groovy_space_assignment_syntax
	at org.gradle.internal.instantiation.generator.AsmBackedClassGenerator.logGroovySpaceAssignmentDeprecation(AsmBackedClassGenerator.java:273)
	at io.embrace.android.gradle.plugin.api.EmbraceExtension_Decorated.buildVariantFilter(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323)
	at org.gradle.internal.extensibility.MixInClosurePropertiesAsMethodsDynamicObject.tryInvokeMethod(MixInClosurePropertiesAsMethodsDynamicObject.java:38)

[priettt]

Hello! Thank you for reporting this.

I think this PR should fix the issue: #2212. It will come out in the next release.

In the meantime, could you tell me how you got that warning? Is it shown by Android Studio, or are you running a specific Gradle command?

[jt-gilkeson]

Yes, it's shown by android studio in the build output once you update to the latest Meerkat version (standard stable channel) and update the gradle plugin to 8.10.0 and gradle wrapper to gradle-8.14-bin.zip

[bidetofevil]

HI there - this has been fixed in our latest release, 7.5.0. Feel free to try it out.

[jt-gilkeson]

7.5.0 does appear to fix the isConfigurationCacheRequested issue, but I'm still seeing reports of:

Properties should be assigned using the 'propName = value' syntax. Setting a property via the Gradle-generated 'propName value' or 'propName(value)' syntax in Groovy DSL has been deprecated.
This is scheduled to be removed in Gradle 10.0.
Properties should be assigned using the 'propName = value' syntax. Setting a property via the Gradle-generated 'propName value' or 'propName(value)' syntax in Groovy DSL has been deprecated.
        - Solutions
[enum]  Use assignment ('buildVariantFilter = <value>') instead.

when we use (per the Embrace documentation):

    embrace {
        buildVariantFilter {
            if (it.name.contains("debug")) {
                it.disablePluginForVariant()
                it.disableBytecodeInstrumentationForVariant()
            }
        }
    }

[jt-gilkeson]

Interesting, I tried the following and it appears to fix the issue, you might want to update your documentation so others don't run into this:

embrace {
        buildVariantFilter = {
            if (it.name.contains("debug")) {
                it.disablePluginForVariant()
                it.disableBytecodeInstrumentationForVariant()
            }
        }
    }