Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better defaults for keepAssets? #200

Open
simonihmig opened this issue Sep 13, 2023 · 0 comments
Open

Better defaults for keepAssets? #200

simonihmig opened this issue Sep 13, 2023 · 0 comments

Comments

@simonihmig
Copy link
Collaborator

On a similar note as #193, should we extends keepAssets to more than just CSS?

Thinking of importing static assets like images, which people can do with some custom webpack module rule, or at least when the Asset Import RFC lands. With the default config now, this won't work, as those files would not make it into the /dist build.

Is there actually a good reason to be restrictive here? Having stuff in the output is still pay-as-you-go, so when something extraneous gets there that is never imported, nothing bad will really happen - except for a bit more waste in node_modules, but we already have enough of that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant