fix(api): export handleSchemaCollectionReorder from the handlers barrel (#2814)

The collection reorder route imports its handler from "#api/index.js",
but the schema block in the handlers barrel re-exports by explicit name
and this one was never added. The binding resolved to undefined, so
POST /_emdash/api/schema/collections/reorder threw before it could do
any work and reordering content types in the admin sidebar failed
instead of saving the new order. Field reordering was unaffected
because handleSchemaFieldReorder is in the list.

Typecheck could not have caught this: packages/core/tsconfig.json
excludes src/astro/**, so the route file is outside the program. The
regression test drives the route's POST against a real in-memory SQLite
database and asserts the persisted sort order, which is the layer where
the gap is actually observable.

Closes #2813

Author: markoinla

.changeset/fix-collection-reorder.md

@@ -0,0 +1,5 @@
+---
+"emdash": patch
+---
+
+Fixes reordering content types in the admin sidebar, which failed with a server error instead of saving the new order. Reordering fields within a content type was unaffected.

packages/core/src/api/handlers/index.ts

@@ -110,6 +110,7 @@ export {
 	handleSchemaFieldCreate,
 	handleSchemaFieldUpdate,
 	handleSchemaFieldDelete,
+	handleSchemaCollectionReorder,
 	handleSchemaFieldReorder,
 	handleOrphanedTableList,
 	handleOrphanedTableRegister,

packages/core/tests/unit/api/schema-collections-reorder-route.test.ts

@@ -0,0 +1,51 @@
+import { Role } from "@emdash-cms/auth";
+import type { Kysely } from "kysely";
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
+
+import { POST } from "../../../src/astro/routes/api/schema/collections/reorder.js";
+import type { Database } from "../../../src/database/types.js";
+import { SchemaRegistry } from "../../../src/schema/registry.js";
+import { setupTestDatabase, teardownTestDatabase } from "../../utils/test-db.js";
+
+type RouteContext = Parameters<typeof POST>[0];
+
+describe("schema collections reorder route", () => {
+	let db: Kysely<Database>;
+	let registry: SchemaRegistry;
+
+	beforeEach(async () => {
+		db = await setupTestDatabase();
+		registry = new SchemaRegistry(db);
+		await registry.createCollection({ slug: "posts", label: "Posts" });
+		await registry.createCollection({ slug: "pages", label: "Pages" });
+		await registry.createCollection({ slug: "authors", label: "Authors" });
+	});
+
+	afterEach(async () => {
+		await teardownTestDatabase(db);
+	});
+
+	it("persists the requested sidebar order", async () => {
+		const response = await POST(reorderContext(["posts", "authors", "pages"]));
+
+		expect(response.status).toBe(200);
+
+		const collections = await registry.listCollections();
+		expect(collections.map((collection) => collection.slug)).toEqual(["posts", "authors", "pages"]);
+		expect(collections.map((collection) => collection.sortOrder)).toEqual([0, 1, 2]);
+	});
+
+	function reorderContext(slugs: string[]): RouteContext {
+		return {
+			request: new Request("http://localhost/_emdash/api/schema/collections/reorder", {
+				method: "POST",
+				headers: { "Content-Type": "application/json", "X-EmDash-Request": "1" },
+				body: JSON.stringify({ slugs }),
+			}),
+			locals: {
+				emdash: { db },
+				user: { id: "admin-1", role: Role.ADMIN },
+			},
+		} as RouteContext;
+	}
+});