fix(admin): restore publish date round trip

Author: masonjames

packages/admin/src/components/ContentSettingsPanel.tsx

@@ -25,7 +25,7 @@ import type {
 	UserListItem,
 } from "../lib/api";
 import { fetchBylines } from "../lib/api";
-import { toDatetimeLocalInputValue } from "../lib/datetime-local.js";
+import { fromDatetimeLocalInputValue, toDatetimeLocalInputValue } from "../lib/datetime-local.js";
 import { useDebouncedValue } from "../lib/hooks.js";
 import { cn, slugify } from "../lib/utils";
 import type { CurrentUserInfo } from "./ContentEditor.js";
@@ -410,7 +410,7 @@ export const ContentSettingsPanel = React.memo(function ContentSettingsPanel({
 
 	const handlePublishedDateSubmit = () => {
 		if (publishedDate && onPublishedAtChange) {
-			onPublishedAtChange(new Date(publishedDate).toISOString());
+			onPublishedAtChange(fromDatetimeLocalInputValue(publishedDate));
 		}
 	};
 

packages/admin/tests/components/ContentSettingsPanel.test.tsx

@@ -148,23 +148,6 @@ describe("ContentSettingsPanel", () => {
 	it("lets editors update the publish date of published content", async () => {
 		const onPublishedAtChange = vi.fn();
 		const previousLocale = i18n.locale;
-		const NativeDate = Date;
-		class NonUtcDate extends NativeDate {
-			constructor(value?: string | number | Date) {
-				if (value === "2020-06-01T08:45") {
-					super("2020-06-01T12:45:00.000Z");
-				} else if (typeof value === "string") {
-					super(value);
-				} else if (typeof value === "number") {
-					super(value);
-				} else if (value instanceof NativeDate) {
-					super(value.valueOf());
-				} else {
-					super();
-				}
-			}
-		}
-		vi.stubGlobal("Date", NonUtcDate);
 		i18n.load("ar", {});
 		i18n.activate("ar");
 		try {
@@ -188,10 +171,9 @@ describe("ContentSettingsPanel", () => {
 			await input.fill("2020-06-01T08:45");
 			await screen.getByRole("button", { name: "Update publish date" }).click();
 
-			expect(onPublishedAtChange).toHaveBeenCalledWith("2020-06-01T12:45:00.000Z");
+			expect(onPublishedAtChange).toHaveBeenCalledWith("2020-06-01T08:45:00.000Z");
 		} finally {
 			i18n.activate(previousLocale);
-			vi.unstubAllGlobals();
 		}
 	});