fix(registry-verification): use Windows-valid synthetic URL for createRequire shim - #3070
fix(registry-verification): use Windows-valid synthetic URL for createRequire shim#3070emdashbot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 0f55d64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-moderation
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://bot-fix-2978.try.emdashcms.com, https://bot-fix-2978-emdash-playground.emdash-cms.workers.dev (commit 0f55d64)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
CompletedAll focused checks pass. Publishing revised candidate.
Outcome: The failing Typecheck CI job for the #2978 candidate was actually caused by the release-action dist freshness check (`git diff --exit-code -- apps/release-action/dist/index.js`), not a TypeScript error. The release-action bundles `@emdash-cms/registry-verification`, so changing the verifier’s `createRequire` shim from `file:///emdash-registry-verification.js` to `file:///C:/emdash-registry-verification.js` produced a one-line diff in the generated `apps/release-action/dist/index.js`. The previous candidate had not committed that regenerated bundle. ### What changed
### Verification
The revised candidate has been published. Mode: revise View live dashboard · Run: |
516574d to
b6dec9a
Compare
CompletedRevise fix for #2978: verified Windows-valid createRequire URL, ran tests/typecheck/lint/format, published candidate.
Outcome: Verified the accepted fix for the Windows build failure in `@emdash-cms/registry-verification`. What changed:
Verification:
The exact Windows `createRequire()` error cannot be reproduced in this Linux workspace; the new guard rejects the old URL, and the reporter confirmed the preview resolves the Windows build failure. Note: `attw --pack` left a stray `emdash-cms-registry-verification-0.3.0.tgz` in the package directory, which was inadvertently included in the published candidate commit. It is not part of the intended fix. candidate branch changed since this run started (expected b6dec9a, found 0f55d64) Failed stage: publication Mode: revise View live dashboard · Run: |
…eRequire shim EmDash-Run: 1f5940f5-3319-4192-b510-d4d2158613cb
b6dec9a to
0f55d64
Compare
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
What does this PR do?
The
@emdash-cms/registry-verification@0.3.0ESM bundle contained a drivelessfile:///emdash-registry-verification.jsURL for thecreateRequireCJS-interop shim. On WindowsfileURLToPath()rejects that URL, so any consumer that inlines the package (such asemdash@0.37.0) fails to load the Astro config.This change updates the
rebundleSafeRequireplugin to emitfile:///C:/emdash-registry-verification.js, which is accepted as an absolute file URL on every platform, and adds a regression guard toscripts/check-packed-output.mjsso the packed output is validated for a Windows-safe drive letter.Verification
dist/index.jsand confirmed the shim now uses the drive-letter URLpnpm --filter @emdash-cms/registry-verification test+test:packagepasspnpm typecheck,pnpm lint:json, andpnpm lint:quickare cleanFixes #2978
Closes #2978.
A candidate change the reporter confirmed against their own site via the preview build:
Opened automatically by emdashbot as a draft. A maintainer must review before merge.
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output