Skip to content

Commit 1c4f1f6

Browse files
committed
[pinpoint-apm#12419] Remove unused json field in ServerMap
1 parent c5c6d54 commit 1c4f1f6

File tree

2 files changed

+1
-61
lines changed

2 files changed

+1
-61
lines changed

web/src/main/java/com/navercorp/pinpoint/web/applicationmap/view/LinkView.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,6 @@ public void serialize(LinkView linkView, JsonGenerator jgen, SerializerProvider
6060
jgen.writeObjectField("from", link.getFrom().getNodeName()); // necessary for go.js
6161
jgen.writeObjectField("to", link.getTo().getNodeName()); // necessary for go.js
6262

63-
// for FilterWizard. from, to agent mapping data
64-
writeAgentId("fromAgent", link.getFrom(), jgen);
65-
writeAgentId("toAgent", link.getTo(), jgen);
66-
67-
//for FilterWizard. show agent name as tooltip on instance
68-
// writeAgentIdNameMap("fromAgentIdNameMap", link.getFrom(), jgen);
69-
// writeAgentIdNameMap("toAgentIdNameMap", link.getTo(), jgen);
70-
7163
// for FilterWizard, to agent mapping data
7264
writeAgents("fromAgents", link.getFrom(), jgen);
7365
writeAgents("toAgents", link.getFrom(), jgen);
@@ -116,13 +108,6 @@ public void serialize(LinkView linkView, JsonGenerator jgen, SerializerProvider
116108

117109
private void writerFilterHint(Link link, JsonGenerator jgen) throws IOException {
118110
Application filterApplication = link.getFilterApplication();
119-
jgen.writeStringField("filterApplicationName", filterApplication.getName());
120-
jgen.writeNumberField("filterApplicationServiceTypeCode", filterApplication.getServiceTypeCode());
121-
jgen.writeStringField("filterApplicationServiceTypeName", filterApplication.getServiceType().getName());
122-
if (link.isWasToWasLink()) {
123-
writeWasToWasTargetRpcList("filterTargetRpcList", link, jgen);
124-
}
125-
126111
jgen.writeFieldName("filter");
127112
jgen.writeStartObject();
128113
jgen.writeStringField("applicationName", filterApplication.getName());
@@ -148,21 +133,6 @@ private void writeAgentId(String fieldName, Node node, JsonGenerator jgen) throw
148133
}
149134
}
150135

151-
@Deprecated
152-
private void writeAgentIdNameMap(String fieldName, Node node, JsonGenerator jgen) throws IOException {
153-
if (node.getServiceType().isWas()) {
154-
jgen.writeFieldName(fieldName);
155-
jgen.writeStartObject();
156-
ServerGroupList serverGroupList = node.getServerGroupList();
157-
if (serverGroupList != null) {
158-
for (Map.Entry<String, String> entry : serverGroupList.getAgentIdNameMap().entrySet()) {
159-
jgen.writeStringField(entry.getKey(), entry.getValue());
160-
}
161-
}
162-
jgen.writeEndObject();
163-
}
164-
}
165-
166136
private void writeAgents(String fieldName, Node node, JsonGenerator jgen) throws IOException {
167137
if (node.getServiceType().isWas()) {
168138
jgen.writeFieldName(fieldName);

web/src/main/java/com/navercorp/pinpoint/web/applicationmap/view/NodeView.java

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,12 @@ static class NodeViewSerializer extends JsonSerializer<NodeView> {
5959

6060
public static final String AGENT_TIME_SERIES_HISTOGRAM = "agentTimeSeriesHistogram";
6161

62-
public static final String AGENTID_NAME_MAP_KEY = "agentIdNameMap";
63-
6462
@Override
6563
public void serialize(NodeView nodeView, JsonGenerator jgen, SerializerProvider provider) throws IOException {
6664
Node node = nodeView.getNode();
6765

6866
jgen.writeStartObject();
69-
// jgen.writeStringField("id", node.getNodeName());serverInstanceList
67+
// jgen.writeStringField("id", node.getNodeName()); serverInstanceList
7068
jgen.writeObjectField("key", node.getNodeName()); // necessary for go.js
7169

7270
jgen.writeStringField("applicationName", node.getApplicationTextName()); // for go.js
@@ -75,13 +73,6 @@ public void serialize(NodeView nodeView, JsonGenerator jgen, SerializerProvider
7573
jgen.writeStringField("serviceType", node.getServiceType().toString());
7674

7775
final ServiceType serviceType = node.getApplication().getServiceType();
78-
// if (serviceType.isUser()) {
79-
// jgen.writeStringField("fig", "Ellipse");
80-
// } else if(serviceType.isWas()) {
81-
// jgen.writeStringField("fig", "RoundedRectangle");
82-
// } else {
83-
// jgen.writeStringField("fig", "Rectangle");
84-
// }
8576

8677
jgen.writeNumberField("serviceTypeCode", serviceType.getCode());
8778
// jgen.writeStringField("terminal", Boolean.toString(serviceType.isTerminal()));
@@ -107,8 +98,6 @@ private void writeServerGroupList(NodeView nodeView, JsonGenerator jgen) throws
10798
if (serverGroupList == null) {
10899
jgen.writeNumberField("instanceCount", 0);
109100
jgen.writeNumberField("instanceErrorCount", 0);
110-
JacksonWriterUtils.writeEmptyArray(jgen, "agentIds");
111-
// JacksonWriterUtils.writeEmptyObject(jgen, AGENTID_NAME_MAP_KEY);
112101
JacksonWriterUtils.writeEmptyArray(jgen, "agents");
113102

114103
if (activeView.isDetailed()) {
@@ -118,8 +107,6 @@ private void writeServerGroupList(NodeView nodeView, JsonGenerator jgen) throws
118107
jgen.writeNumberField("instanceCount", serverGroupList.getInstanceCount());
119108
long instanceErrorCount = getInstanceErrorCount(node);
120109
jgen.writeNumberField("instanceErrorCount", instanceErrorCount);
121-
writeAgentIds("agentIds", serverGroupList, jgen);
122-
// writeAgentIdMap(AGENTID_NAME_MAP_KEY, serverGroupList, jgen);
123110
writeAgentList("agents", serverGroupList, jgen);
124111

125112
if (activeView.isDetailed()) {
@@ -128,23 +115,6 @@ private void writeServerGroupList(NodeView nodeView, JsonGenerator jgen) throws
128115
}
129116
}
130117

131-
private void writeAgentIds(String fieldName, ServerGroupList serverGroupList, JsonGenerator jgen) throws IOException {
132-
jgen.writeArrayFieldStart(fieldName);
133-
for (String agentId : serverGroupList.getAgentIdList()) {
134-
jgen.writeString(agentId);
135-
}
136-
jgen.writeEndArray();
137-
}
138-
139-
@Deprecated
140-
private void writeAgentIdMap(String fieldName, ServerGroupList serverGroupList, JsonGenerator jgen) throws IOException {
141-
jgen.writeObjectFieldStart(fieldName);
142-
for (Map.Entry<String, String> entry : serverGroupList.getAgentIdNameMap().entrySet()) {
143-
jgen.writeStringField(entry.getKey(), entry.getValue());
144-
}
145-
jgen.writeEndObject();
146-
}
147-
148118
private void writeAgentList(String fieldName, ServerGroupList serverGroupList, JsonGenerator jgen) throws IOException {
149119
jgen.writeFieldName(fieldName);
150120
jgen.writeStartArray();

0 commit comments

Comments
 (0)