cargo test failed at test test_demo_app .

[John-Nagle]

Describe the bug

test test_demo_app ... FAILED

failures:

---- test_demo_app stdout ----
thread 'test_demo_app' panicked at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ptr/mod.rs:542:1:
Snapshot errors:
  Error decoding snapshot: Decoding(DecodingError { format: Exact(Png), underlying: Some(Format(FormatError { inner: InvalidSignature })) })
At: "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/easymarkeditor.png". Make sure git-lfs is setup correctly. Read the instructions here: https://github.com/emilk/egui/blob/master/CONTRIBUTING.md#making-a-pr
  Error decoding snapshot: Decoding(DecodingError { format: Exact(Png), underlying: Some(Format(FormatError { inner: InvalidSignature })) })
At: "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/clock.png". Make sure git-lfs is setup correctly. Read the instructions here: https://github.com/emilk/egui/blob/master/CONTRIBUTING.md#making-a-pr

stack backtrace:
   0: rust_begin_unwind
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:74:14
   2: core::panicking::panic_display
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:264:5
   3: <egui_kittest::snapshot::SnapshotResults as core::ops::drop::Drop>::drop::panic_cold_display
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panic.rs:101:13
   4: <egui_kittest::snapshot::SnapshotResults as core::ops::drop::Drop>::drop
             at /home/john/projects/egui/crates/egui_kittest/src/snapshot.rs:591:13
   5: core::ptr::drop_in_place<egui_kittest::snapshot::SnapshotResults>
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ptr/mod.rs:542:1
   6: test_demo_app::test_demo_app
             at ./tests/test_demo_app.rs:74:1
   7: test_demo_app::test_demo_app::{{closure}}
             at ./tests/test_demo_app.rs:8:19
   8: core::ops::function::FnOnce::call_once
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5
   9: core::ops::function::FnOnce::call_once
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    test_demo_app

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.70s

To Reproduce
Steps to reproduce the behavior:

1. Check out current master of egui
2. cargo test

Expected behavior

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 22.04.5 LTS

Additional context

[John-Nagle]

Building egui from "master" currently leads to compile errors for two incompatible versions of "eframe" being pulled in. Looks like that's being edited, with recent check-ins, and "master" is not in a consistent state.

Also, cross-compile to Windows for test leads to, of all things, creating more than 65535 symbols, and the linker aborts. See

rust-lang/rust#140237 (comment)

That's weird.

[lucasmerlin]

The images for snapshot tests are stored in git-lfs. Did you set that up correctly? If you open e.g. egui/crates/egui_demo_app/tests/snapshots/easymarkeditor.png, is it displayed as an image?

[lucasmerlin]

There is some info in CONTRIBUTING.md on how to set it up

[John-Nagle]

Right, I needed to set up lfs. But the file the test needs still shows "Invalid signature".

test test_demo_app ... FAILED

failures:

---- test_demo_app stdout ----
thread 'test_demo_app' panicked at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ptr/mod.rs:542:1:
Snapshot errors:
  Error decoding snapshot: Decoding(DecodingError { format: Exact(Png), underlying: Some(Format(FormatError { inner: InvalidSignature })) })
At: "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/easymarkeditor.png". Make sure git-lfs is setup correctly. Read the instructions here: https://github.com/emilk/egui/blob/master/CONTRIBUTING.md#making-a-pr
  Error decoding snapshot: Decoding(DecodingError { format: Exact(Png), underlying: Some(Format(FormatError { inner: InvalidSignature })) })
At: "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/clock.png". Make sure git-lfs is setup correctly. Read the instructions here: https://github.com/emilk/egui/blob/master/CONTRIBUTING.md#making-a-pr

LFS knows about the files:

> git lfs ls-files
61db3807f7 - crates/egui_demo_app/tests/snapshots/clock.png
21e0a6cdf1 - crates/egui_demo_app/tests/snapshots/custom3d.png
3e6a383dca - crates/egui_demo_app/tests/snapshots/easymarkeditor.png
f7572ec2da - crates/egui_demo_app/tests/snapshots/imageviewer.png
... (lots more)

They're loaded in the right place:

> ls -l /home/john/projects/egui/crates/egui_demo_app/tests/snapshots
total 512
-rw-rw-r-- 1 john john 330140 Apr 28 20:12 clock.new.png
-rw-rw-r-- 1 john john    131 Apr 23 19:33 clock.png
-rw-rw-r-- 1 john john    130 Apr 23 19:33 custom3d.png
-rw-rw-r-- 1 john john 174806 Apr 28 20:12 easymarkeditor.new.png
-rw-rw-r-- 1 john john    131 Apr 23 19:33 easymarkeditor.png
-rw-rw-r-- 1 john john    131 Apr 23 19:33 imageviewer.png

Some kind of versioning problem, perhaps? Did I grab "master" at an invalid moment?

[John-Nagle]

I see what's happening. What's actually in "easymarkededitor.png" is the text:

version https://git-lfs.github.com/spec/v1
oid sha256:3e6a383dca7e91d07df4bf501e2de13d046f04546a08d026efe3f82fc96b6e29
size 178887

while the actual image is in "easymarkededitor.new.png".

The egui test harness in "snapshot.rs" seems to be under development in "master".

So I re-fetched the egui project and tried "cargo test" again.
That got me commit c075053.

Now "cargo test" produces:

running 1 test
test test_demo_app ... FAILED

failures:

---- test_demo_app stdout ----
thread 'test_demo_app' panicked at /rustc/9fc6b43126469e3858e2fe86cafb4f0fd5068869/library/core/src/ptr/mod.rs:521:1:
Snapshot errors:
  'easymarkeditor' Image did not match snapshot. Diff: 926, "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/easymarkeditor.diff.png". Run `UPDATE_SNAPSHOTS=1 cargo test --all-features` to update the snapshots.
  'clock' Image did not match snapshot. Diff: 2421, "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/clock.diff.png". Run `UPDATE_SNAPSHOTS=1 cargo test --all-features` to update the snapshots.

Now this is a legit miscompare between the provided "correct" image and the one generated. Here's the diff:

Now I get it. I'm building a work in progress, not a release.

It would be appreciated if egui development took place in another branch and was pulled to master at the same time crates.io is updated. That would make it much simpler when chasing down egui bugs. Thank you.

[lucasmerlin]

It would be appreciated if egui development took place in another branch and was pulled to master at the same time crates.io is updated. That would make it much simpler when chasing down egui bugs. Thank you.

You can look at the tags to find the commit for each release:

[John-Nagle]

Tried 0.31.1, same version as crates.io:

git status
HEAD detached at 0.31.1
nothing to commit, working tree clean

Same bug:

running 1 test
test test_demo_app ... FAILED

failures:

---- test_demo_app stdout ----
thread 'test_demo_app' panicked at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ptr/mod.rs:542:1:
Snapshot errors:
  'easymarkeditor' Image did not match snapshot. Diff: 950, "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/easymarkeditor.diff.png". Run `UPDATE_SNAPSHOTS=1 cargo test --all-features` to update the snapshots.
  'clock' Image did not match snapshot. Diff: 2420, "/home/john/projects/egui/crates/egui_demo_app/tests/snapshots/clock.diff.png". Run `UPDATE_SNAPSHOTS=1 cargo test --all-features` to update the snapshots.

stack backtrace:
   0: rust_begin_unwind
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:74:14
   2: core::panicking::panic_display
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panicking.rs:264:5
   3: <egui_kittest::snapshot::SnapshotResults as core::ops::drop::Drop>::drop::panic_cold_display
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/panic.rs:101:13
   4: <egui_kittest::snapshot::SnapshotResults as core::ops::drop::Drop>::drop
             at /home/john/projects/egui/crates/egui_kittest/src/snapshot.rs:591:13
   5: core::ptr::drop_in_place<egui_kittest::snapshot::SnapshotResults>
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ptr/mod.rs:542:1
   6: test_demo_app::test_demo_app
             at ./tests/test_demo_app.rs:74:1
   7: test_demo_app::test_demo_app::{{closure}}
             at ./tests/test_demo_app.rs:8:19
   8: core::ops::function::FnOnce::call_once
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5
   9: core::ops::function::FnOnce::call_once
             at /rustc/eeb90cda1969383f56a2637cbd3037bdf598841c/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    test_demo_app

Same image diff.

It's minor, but it is a failure of "cargo test" on the release version.

[John-Nagle]

This is preliminary work so I can try to chase down #6847

I need a version that's known to work before I go looking for obscure cross-compile errors.

[John-Nagle]

Tried
cargo test --target x86_64-pc-windows-gnu --release

on 0.31.1. Result: version clash on "eframe".

error[E0308]: mismatched types
   --> crates/egui_demo_app/tests/test_demo_app.rs:12:41
    |
12  |         .build_eframe(|cc| WrapApp::new(cc));
    |                            ------------ ^^ expected `&CreationContext<'_>`, found `&mut CreationContext<'_>`
    |                            |
    |                            arguments to this function are incorrect
    |
    = note: `eframe::epi::CreationContext<'_>` and `eframe::epi::CreationContext<'_>` have similar names, but are actually distinct types
note: `eframe::epi::CreationContext<'_>` is defined in crate `eframe`
   --> /home/john/projects/egui/crates/eframe/src/epi.rs:53:1
    |
53  | pub struct CreationContext<'s> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: `eframe::epi::CreationContext<'_>` is defined in crate `eframe`
   --> /home/john/projects/egui/crates/eframe/src/epi.rs:53:1
    |
53  | pub struct CreationContext<'s> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `eframe` are being used?
note: associated function defined here
   --> /home/john/projects/egui/crates/egui_demo_app/src/wrap_app.rs:187:12
    |
187 |     pub fn new(cc: &eframe::CreationContext<'_>) -> Self {
    |            ^^^

error[E0277]: the trait bound `WrapApp: eframe::epi::App` is not satisfied
   --> crates/egui_demo_app/tests/test_demo_app.rs:12:10
    |
12  |         .build_eframe(|cc| WrapApp::new(cc));
    |          ^^^^^^^^^^^^ the trait `eframe::epi::App` is not implemented for `WrapApp`
    |
help: trait impl with same name found
   --> /home/john/projects/egui/crates/egui_demo_app/src/wrap_app.rs:263:1
    |
263 | impl eframe::App for WrapApp {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `eframe` are being used?
note: required by a bound in `HarnessBuilder::<State>::build_eframe`
   --> /home/john/projects/egui/crates/egui_kittest/src/builder.rs:158:16
    |
153 |     pub fn build_eframe<'a>(
    |            ------------ required by a bound in this associated function
...
158 |         State: eframe::App,
    |                ^^^^^^^^^^^ required by this bound in `HarnessBuilder::<State>::build_eframe`