Skip to content

Make Span and Metric pull well-known props from P instead of direct fields #376

@KodrAus

Description

@KodrAus

Currently, Span doesn't accept a SpanCtxt on construction because that should be part of the ambient context. This makes its representation incomplete, and puts the span context at a different level than the span name.

If we add SpanCtxt to Span and start including it in the Event's props when emitting it, we'll end up duplicating those properties. It's not technically an issue, it just looks a bit weird when you're using a non-deduplicating representation like fmt::Debug. It would be nice to work around this if we can, but I think that's the lesser issue than having Span not carry its own context.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions