Skip to content
This repository was archived by the owner on Jun 29, 2024. It is now read-only.

Commit 44056d9

Browse files
committed
Rename UCEVCC api
The name should fit the scenario description and not confuse with currents
1 parent 6697f4d commit 44056d9

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

ucevcc/api.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ type UCEVCCInterface interface {
6666
//
6767
// parameters:
6868
// - entity: the entity of the EV
69-
CurrentLimits(entity spineapi.EntityRemoteInterface) (float64, float64, float64, error)
69+
ChargingPowerLimits(entity spineapi.EntityRemoteInterface) (float64, float64, float64, error)
7070

7171
// Scenario 7
7272

ucevcc/public.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ func (e *UCEVCC) ManufacturerData(
210210
// possible errors:
211211
// - ErrDataNotAvailable if no such measurement is (yet) available
212212
// - and others
213-
func (e *UCEVCC) CurrentLimits(entity spineapi.EntityRemoteInterface) (float64, float64, float64, error) {
213+
func (e *UCEVCC) ChargingPowerLimits(entity spineapi.EntityRemoteInterface) (float64, float64, float64, error) {
214214
if !util.IsCompatibleEntity(entity, e.validEntityTypes) {
215215
return 0.0, 0.0, 0.0, api.ErrNoCompatibleEntity
216216
}

ucevcc/public_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -291,14 +291,14 @@ func (s *UCEVCCSuite) Test_EVManufacturerData() {
291291
assert.Equal(s.T(), "", data.BrandName)
292292
}
293293

294-
func (s *UCEVCCSuite) Test_EVCurrentLimits() {
295-
minData, maxData, standByData, err := s.sut.CurrentLimits(s.mockRemoteEntity)
294+
func (s *UCEVCCSuite) Test_EVChargingPowerLimits() {
295+
minData, maxData, standByData, err := s.sut.ChargingPowerLimits(s.mockRemoteEntity)
296296
assert.NotNil(s.T(), err)
297297
assert.Equal(s.T(), 0.0, minData)
298298
assert.Equal(s.T(), 0.0, maxData)
299299
assert.Equal(s.T(), 0.0, standByData)
300300

301-
minData, maxData, standByData, err = s.sut.CurrentLimits(s.evEntity)
301+
minData, maxData, standByData, err = s.sut.ChargingPowerLimits(s.evEntity)
302302
assert.NotNil(s.T(), err)
303303
assert.Equal(s.T(), 0.0, minData)
304304
assert.Equal(s.T(), 0.0, maxData)
@@ -318,7 +318,7 @@ func (s *UCEVCCSuite) Test_EVCurrentLimits() {
318318
fErr := rFeature.UpdateData(model.FunctionTypeElectricalConnectionParameterDescriptionListData, paramData, nil, nil)
319319
assert.Nil(s.T(), fErr)
320320

321-
minData, maxData, standByData, err = s.sut.CurrentLimits(s.evEntity)
321+
minData, maxData, standByData, err = s.sut.ChargingPowerLimits(s.evEntity)
322322
assert.NotNil(s.T(), err)
323323
assert.Equal(s.T(), 0.0, minData)
324324
assert.Equal(s.T(), 0.0, maxData)
@@ -377,7 +377,7 @@ func (s *UCEVCCSuite) Test_EVCurrentLimits() {
377377
fErr := rFeature.UpdateData(model.FunctionTypeElectricalConnectionPermittedValueSetListData, permData, nil, nil)
378378
assert.Nil(s.T(), fErr)
379379

380-
minData, maxData, standByData, err = s.sut.CurrentLimits(s.evEntity)
380+
minData, maxData, standByData, err = s.sut.ChargingPowerLimits(s.evEntity)
381381
assert.Nil(s.T(), err)
382382

383383
assert.Nil(s.T(), err)

0 commit comments

Comments
 (0)