Skip to content
This repository was archived by the owner on Jun 29, 2024. It is now read-only.

Commit b8055aa

Browse files
uclpcserver: align electricalConnectionCharacteristicListData operations (#29)
in Limitation of Power Consumption v1.0.0 section 3.2.2.2.1 the ListData is declared only readable
2 parents 909839c + 405481f commit b8055aa

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

uclpcserver/uclpc.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ func (e *UCLPCServer) AddFeatures() {
9494
f.AddFunctionType(model.FunctionTypeDeviceConfigurationKeyValueListData, true, true)
9595

9696
var configId model.DeviceConfigurationKeyIdType = 0
97-
// get the heighest keyId
97+
// get the highest keyId
9898
if desc, err := spine.LocalFeatureDataCopyOfType[*model.DeviceConfigurationKeyValueDescriptionListDataType](
9999
f, model.FunctionTypeDeviceConfigurationKeyValueDescriptionListData); err == nil && desc.DeviceConfigurationKeyValueDescriptionData != nil {
100100
for _, desc := range desc.DeviceConfigurationKeyValueDescriptionData {
@@ -139,10 +139,10 @@ func (e *UCLPCServer) AddFeatures() {
139139
f.AddFunctionType(model.FunctionTypeDeviceDiagnosisHeartbeatData, true, false)
140140

141141
f = localEntity.GetOrAddFeature(model.FeatureTypeTypeElectricalConnection, model.RoleTypeServer)
142-
f.AddFunctionType(model.FunctionTypeElectricalConnectionCharacteristicListData, true, true)
142+
f.AddFunctionType(model.FunctionTypeElectricalConnectionCharacteristicListData, true, false)
143143

144144
var elCharId model.ElectricalConnectionCharacteristicIdType = 0
145-
// get the heighest CharacteristicId
145+
// get the highest CharacteristicId
146146
if desc, err := spine.LocalFeatureDataCopyOfType[*model.ElectricalConnectionCharacteristicListDataType](
147147
f, model.FunctionTypeElectricalConnectionCharacteristicListData); err == nil && desc.ElectricalConnectionCharacteristicData != nil {
148148
for _, desc := range desc.ElectricalConnectionCharacteristicData {

0 commit comments

Comments
 (0)