Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bootstrap 4.5.0 #7327

Open
tomchristie opened this issue May 13, 2020 · 20 comments · May be fixed by #7411
Open

Update to Bootstrap 4.5.0 #7327

tomchristie opened this issue May 13, 2020 · 20 comments · May be fixed by #7411

Comments

@tomchristie
Copy link
Member

https://blog.getbootstrap.com/2020/05/12/bootstrap-4-5-0/
Related: #7313

@tomchristie tomchristie added this to the 3.12 Release milestone May 13, 2020
@auvipy
Copy link
Member

auvipy commented May 13, 2020

mainly the browsable API/ admin stuffs?

@carltongibson
Copy link
Collaborator

Issue here is that we're still on Bootstrap v3.x, and the upgrade to v4.x isn't just a swap it in. There's HTML changes throughout, which make it a good mini-project for a willing contributor.

@tomchristie
Copy link
Member Author

@carltongibson Something that’s not 100% clear to me. Are we okay with the jQuery update we’ve made?

@tomchristie
Copy link
Member Author

I guess so, since it oughta be backwards compatible

@carltongibson
Copy link
Collaborator

Yeah... I believe so. Bar some dropping of browsers we don't support jQuery hasn't broken anything for a long while.

@smithdc1
Copy link
Contributor

smithdc1 commented Jul 8, 2020

@carltongibson -- I'd be willing to have a go at this if you think I have the skills (It is 'just' template layouts and bootstrap right...).

@auvipy
Copy link
Member

auvipy commented Jul 8, 2020

@carltongibson -- I'd be willing to have a go at this if you think I have the skills (It is 'just' template layouts and bootstrap right...).

kind of yes.

@carltongibson
Copy link
Collaborator

@smithdc1: yes, it’s exactly that. Updating the Browsable API templates to use the newer version. (I didn’t look into it but I see v5 is on the way — don’t know if it’s worth skipping straight to that?)

@smithdc1
Copy link
Contributor

smithdc1 commented Jul 9, 2020

Yes v5 in alpha and a few alpha releases expected over the coming months weeks/months, my guess is v5 will be out in Q4. The main thing with v5 is it no longer depends upon jQuery. The upgrade from v4-v5 should be much easier than v3-v4.

I'll go investigate.

@auvipy
Copy link
Member

auvipy commented Jul 9, 2020

Yes v5 in alpha and a few alpha releases expected over the coming months weeks/months, my guess is v5 will be out in Q4. The main thing with v5 is it no longer depends upon jQuery. The upgrade from v4-v5 should be much easier than v3-v4.

I'll go investigate.

agree

@carltongibson
Copy link
Collaborator

Super. Thanks. 🥇

@smithdc1 smithdc1 linked a pull request Jul 12, 2020 that will close this issue
2 tasks
@smithdc1
Copy link
Contributor

On the topic of updating themes... What about the docs, they seem to be on bootstrap 2?

@carltongibson
Copy link
Collaborator

@smithdc1 The docs are a mkdocs theme. In docs_theme. Maybe if you have energy, but one thing at a time I'd say... 😬

@joshjung
Copy link

Any updates on this? Our team needs this for a security audit for medical industry. I'm not sure why Bootstrap 3.x is considered a security hole, but the hospitals are going to get the security audit report and they probably will not be able to be convinced that Bootstrap 3 javascript for dropdowns and form elements is not a security hole. We are kindof stuck :(

@jscaux
Copy link

jscaux commented May 31, 2021

Suggestion: bypass this and go straight for Bootstrap v5, see #7411.

@jeffersonataide
Copy link

@carltongibson If possible, I would like to work on updating MkDocs theme in docs_theme to BS5. I checked #7411, and it's about the version for the templates. Although it does have some file changes inside docs_theme.

@carltongibson
Copy link
Collaborator

@jefferson2z — I'm sure @tomchristie would be happy to see input on updating the docs theme. #7411 is about bringing the Browseable API up to the latest bootstrap. I'm sure input would be welcome there too! 😀

@tomchristie tomchristie modified the milestones: 3.13 Release, 3.14 Jan 10, 2022
@stale
Copy link

stale bot commented Mar 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 27, 2022
@auvipy auvipy removed the stale label Jan 6, 2023
@auvipy auvipy removed this from the 3.15 milestone Jul 11, 2023
@sww314
Copy link

sww314 commented Jan 3, 2024

As others have mentioned, the old version of bootstrap comes up in security audits. Moving to v5 would be great.

#9028

@metal3d
Copy link

metal3d commented Sep 29, 2024

Sadly, I don't have time to look at the whole code, but I'm still wondering: how can it take so long to switch to bootstrap v5?

I mean, we're talking about CSS classes and I don't think there are that many templates to modify. We're stuck on a version 3 of bootstrap that's a bit “old-fashioned” and that makes the presentation not very attractive.

I'm trying to introduce Django RestFramework to my company, and I have to be honest about the fact that the design isn't very convincing. I understand that views aren't the most important part of converting, but you know how it is... project managers... customers... they like “wow” effects.

Translated with DeepL.com (free version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants