Merge pull request #9 from encryption4all/fix/code-quality-housekeeping

chore: clippy fix, MSRV declaration, Signature PartialEq/Eq

Author: rubenhensen

Cargo.toml

@@ -3,6 +3,7 @@ name = "ibs"
 version = "0.4.0"
 authors = ["Leon Botros <l.botros@cs.ru.nl>"]
 edition = "2021"
+rust-version = "1.65"
 categories = ["cryptography", "no-std", "elliptic-curve", "identity-based"]
 description = "Identity-Based Signature schemes"
 keywords = ["ibs", "signatures", "ecc", "no_std"]

src/gg.rs

@@ -87,7 +87,7 @@ pub struct UserSecretKey {
 pub const SIG_BYTES: usize = 96;
 
 /// Signature.
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 pub struct Signature {
     ga: RistrettoPoint,
@@ -228,7 +228,7 @@ fn h_helper(gr: &RistrettoPoint, id: &Identity) -> Scalar {
     let mut h = Sha3_512::new();
 
     Digest::update(&mut h, gr.compress().as_bytes());
-    Digest::update(&mut h, &id.0);
+    Digest::update(&mut h, id.0);
 
     Scalar::from_hash(h)
 }
@@ -447,6 +447,19 @@ mod tests {
             .verify(&pk_recovered, &sig_recovered, &id));
     }
 
+    #[test]
+    fn test_signature_eq() {
+        let (_, usk, _) = default_setup();
+        let message = b"message under test";
+
+        let sig = Signer::new().chain(message).sign(&usk, &mut OsRng);
+        let sig_clone = sig.clone();
+        assert_eq!(sig, sig_clone);
+
+        let sig_other = Signer::new().chain(message).sign(&usk, &mut OsRng);
+        assert_ne!(sig, sig_other);
+    }
+
     #[test]
     fn test_byte_roundtrip_public_key() {
         let (pk, _) = setup(&mut OsRng);