fix: resolve all svelte-check errors

- Fix db.execute to use sql tagged template with sql.raw for dynamic column
- Replace parent() with locals.session in all portal form actions
- Add yivi-css type declaration (src/yivi-css.d.ts)
- Use any types for Yivi SDK callback parameters
- Cast flag key in admin settings template
- Use consistent Record<string, string> for register form errors
- Use explicit FormResult interface in register page component

0 errors, 2 warnings (intentional state_referenced_locally)

Author: rubenhensen

src/lib/components/YiviLogin.svelte

@@ -38,7 +38,7 @@
 				session: {
 					url: '/irma',
 					start: {
-						url: (o: { url: string }) => `${o.url}/session`,
+						url: (o: any) => `${o.url}/session`,
 						method: 'POST',
 						headers: { 'Content-Type': 'application/json' },
 						body: JSON.stringify({
@@ -47,12 +47,12 @@
 						})
 					},
 					mapping: {
-						sessionPtr: (r: { sessionPtr: unknown }) => r.sessionPtr,
-						sessionToken: (r: { token: string }) => {
+						sessionPtr: (r: any) => r.sessionPtr,
+						sessionToken: (r: any) => {
 							irmaToken = r.token;
 							return r.token;
 						},
-						frontendRequest: (r: { frontendRequest?: unknown }) => r.frontendRequest
+						frontendRequest: (r: any) => r.frontendRequest
 					}
 				},
 				state: {

src/lib/server/services/admin.ts

@@ -6,7 +6,7 @@ import {
 	apiKeys,
 	adminAccounts
 } from '$lib/server/db/schema';
-import { eq, desc, and, isNull, or, count } from 'drizzle-orm';
+import { eq, desc, and, isNull, or, count, sql } from 'drizzle-orm';
 
 export async function logAdminAction(
 	adminId: string,
@@ -90,10 +90,7 @@ export async function approveChangeRequest(
 
 	if (fieldMap[req.fieldName]) {
 		// Use raw SQL for dynamic column update
-		await db.execute(
-			`UPDATE organizations SET ${fieldMap[req.fieldName]} = $1, updated_at = NOW() WHERE id = $2`,
-			[req.newValue, req.orgId]
-		);
+		await db.execute(sql`UPDATE organizations SET ${sql.raw(fieldMap[req.fieldName])} = ${req.newValue}, updated_at = NOW() WHERE id = ${req.orgId}`);
 	}
 
 	await db

src/routes/(admin)/admin/settings/+page.svelte

@@ -42,7 +42,7 @@
 		{#each Object.entries(flags) as [flag, info]}
 			<div class="flag-row">
 				<div class="flag-info">
-					<span class="flag-label">{data.labels[flag]}</span>
+					<span class="flag-label">{data.labels[flag as keyof typeof data.labels]}</span>
 					<span class="flag-key">{flag}</span>
 				</div>
 				<div class="flag-controls">

src/routes/(marketing)/register/+page.server.ts

@@ -14,7 +14,10 @@ export function load() {
 export const actions: Actions = {
 	default: async ({ request }) => {
 		if (!isEnabled('registration')) {
-			return fail(404, { error: 'Not found' });
+			return fail(404, {
+				errors: { form: 'Not found' } as Record<string, string>,
+				values: { name: '', domain: '', email: '', contactName: '', phone: null, kvkNumber: null }
+			});
 		}
 
 		const data = await request.formData();
@@ -63,12 +66,12 @@ export const actions: Actions = {
 		} catch (err: unknown) {
 			if (err instanceof Error && err.message.includes('unique')) {
 				return fail(409, {
-					errors: { domain: 'This domain is already registered' },
+					errors: { domain: 'This domain is already registered' } as Record<string, string>,
 					values: { name, domain, email, contactName, phone, kvkNumber }
 				});
 			}
 			return fail(500, {
-				errors: { form: 'An unexpected error occurred. Please try again.' },
+				errors: { form: 'An unexpected error occurred. Please try again.' } as Record<string, string>,
 				values: { name, domain, email, contactName, phone, kvkNumber }
 			});
 		}

src/routes/(marketing)/register/+page.svelte

@@ -2,9 +2,14 @@
 	import SEO from '$lib/components/SEO.svelte';
 	import { enhance } from '$app/forms';
 	import Icon from '@iconify/svelte';
-	import type { ActionData } from './$types';
 
-	let { form }: { form: ActionData } = $props();
+	interface FormResult {
+		success?: boolean;
+		errors?: Record<string, string>;
+		values?: Record<string, string | null | undefined>;
+	}
+
+	let { form }: { form: FormResult | null } = $props();
 </script>
 
 <SEO

src/routes/(portal)/portal/api-keys/+page.server.ts

@@ -11,16 +11,17 @@ export const load: PageServerLoad = async ({ parent }) => {
 };
 
 export const actions: Actions = {
-	revoke: async ({ request, parent }) => {
-		const { organization } = await parent();
+	revoke: async ({ request, locals }) => {
+		const orgId = locals.session?.orgId;
+		if (!orgId) error(401, 'Not authenticated');
 		const data = await request.formData();
 		const keyId = data.get('keyId')?.toString();
 
 		if (!keyId) {
 			return fail(400, { error: 'Missing key ID' });
 		}
 
-		await revokeApiKey(keyId, organization.id);
+		await revokeApiKey(keyId, orgId);
 		return { revoked: true };
 	}
 };

src/routes/(portal)/portal/api-keys/create/+page.server.ts

@@ -8,8 +8,9 @@ export function load() {
 }
 
 export const actions: Actions = {
-	default: async ({ request, parent }) => {
-		const { organization } = await parent();
+	default: async ({ request, locals }) => {
+		const orgId = locals.session?.orgId;
+		if (!orgId) error(401, 'Not authenticated');
 		const data = await request.formData();
 
 		const name = data.get('name')?.toString().trim();
@@ -33,7 +34,7 @@ export const actions: Actions = {
 		const expiresAt = new Date(Date.now() + expiryDays * 24 * 60 * 60 * 1000);
 
 		const rawKey = await createApiKey(
-			organization.id,
+			orgId,
 			name,
 			{
 				orgName: signOrgName,

src/routes/(portal)/portal/dns/+page.server.ts

@@ -14,9 +14,10 @@ export const load: PageServerLoad = async ({ parent }) => {
 };
 
 export const actions: Actions = {
-	verify: async ({ parent }) => {
-		const { organization } = await parent();
-		const result = await verifyDns(organization.id);
+	verify: async ({ locals }) => {
+		const orgId = locals.session?.orgId;
+		if (!orgId) error(401, 'Not authenticated');
+		const result = await verifyDns(orgId);
 		return result;
 	}
 };

src/routes/(portal)/portal/email-log/+page.server.ts

@@ -14,14 +14,15 @@ export const load: PageServerLoad = async ({ parent, url }) => {
 };
 
 export const actions: Actions = {
-	revoke: async ({ request, parent, locals }) => {
-		const { organization } = await parent();
+	revoke: async ({ request, locals }) => {
+		const orgId = locals.session?.orgId;
+		if (!orgId) error(401, 'Not authenticated');
 		const data = await request.formData();
 		const emailId = data.get('emailId')?.toString();
 
 		if (!emailId) return fail(400, { error: 'Missing email ID' });
 
-		await revokeEmail(emailId, organization.id, locals.session?.id ?? 'unknown');
+		await revokeEmail(emailId, orgId, locals.session?.id ?? 'unknown');
 		return { revoked: true };
 	}
 };

src/routes/(portal)/portal/organization/+page.server.ts

@@ -11,8 +11,9 @@ export const load: PageServerLoad = async ({ parent }) => {
 };
 
 export const actions: Actions = {
-	requestChange: async ({ request, parent }) => {
-		const { organization } = await parent();
+	requestChange: async ({ request, locals }) => {
+		const orgId = locals.session?.orgId;
+		if (!orgId) error(401, 'Not authenticated');
 		const data = await request.formData();
 		const fieldName = data.get('fieldName')?.toString();
 		const newValue = data.get('newValue')?.toString().trim();
@@ -22,7 +23,7 @@ export const actions: Actions = {
 			return fail(400, { error: 'Field name and new value are required' });
 		}
 
-		await createChangeRequest(organization.id, fieldName, oldValue, newValue);
+		await createChangeRequest(orgId, fieldName, oldValue, newValue);
 		return { submitted: true, fieldName };
 	}
 };