Add unit/integration test project — no tests currently exist

[dobby-coder]

Problem

The repo has no test project. CI runs dotnet build and dotnet pack but never executes tests. Critical paths are completely unverified:

• src/Crypto/SealPipeline.cs — policy JSON construction (BuildPolicyJson), parallel key fetching, native FFI invocation
• src/Api/CryptifyClient.cs — chunked upload (Content-Range formatting, token rotation across chunks, init/finalize wiring)
• src/Api/PkgClient.cs — JSON parsing of MPK and signing key responses
• src/Zip/ZipHelper.cs — file packing
• Recipient/policy edge cases (e.g. EmailDomain with no @, multiple extras)

Suggested approach

• Add tests/E4A.PostGuard.Tests/ xUnit project, register in E4A.PostGuard.slnx
• Pure unit tests for BuildPolicyJson, ZipHelper, recipient builders, exception types
• Integration tests for the API clients using a mock HttpMessageHandler so the full chunked-upload flow is exercised without a live Cryptify
• Add a dotnet test --configuration Release step to .github/workflows/build.yml between Build and Pack

Why now

Without any tests, refactors (e.g. swapping byte[] → Stream) and dependency bumps land blind. A baseline unit suite makes future work safer.

[dobby-coder]

/dobby fix — Add a test project to the solution so CI actually exercises the code (currently only dotnet build/dotnet pack run). Cover the critical paths called out in the issue: BuildPolicyJson and key-fetch wiring in src/Crypto/SealPipeline.cs, the chunked-upload Content-Range formatting and token rotation in src/Api/CryptifyClient.cs, MPK/signing-key JSON parsing in src/Api/PkgClient.cs, and src/Zip/ZipHelper.cs. Wire the test project into the existing CI so tests run on build. Open a PR per the usual rules.

[dobby-coder]

PR #36 is signed off and ready for review. All 54 tests pass on net10.0 (both TFMs compile), the diff is test-only and accurately mirrors source behaviour — no blocking issues found.

Since GitHub won't let me formally approve a self-authored PR, I left a comment sign-off instead (per the self-authored-PR rule). I've also assigned @rubenhensen as reviewer and flipped the PR out of draft.

One non-blocking note inline: the Content-Range overlap is worth a look when you get a chance, but it's not a blocker.

[dobby-coder]

/dobby fix — Add a unit/integration test project for postguard-dotnet (xUnit or NUnit, matching the .NET version the repo targets). Cover the critical paths the issue lists: BuildPolicyJson policy construction (including EmailDomain with no @, multiple extras), CryptifyClient chunked upload (Content-Range formatting, token rotation across chunks, init/finalize wiring), PkgClient JSON parsing of MPK and signing-key responses, and ZipHelper packing. Run dotnet test locally and open a draft PR closing #10. Note: actually wiring dotnet test into the CI workflow needs a .github/workflows/ edit the bot cannot push — deliver that workflow change as a copy-pastable patch in a PR comment rather than blocking the PR on it.

[dobby-coder]

On it! I'm picking up issue #10 and will create a new test project, open a draft PR with the changes, and run a review loop until everything looks clean.

[dobby-coder]

Status: test project already shipped; only the CI wiring remains (blocked on permissions)

This agent picked up issue #10 and verified the current state of main:

• The tests/E4A.PostGuard.Tests/ xUnit project already exists, is registered in E4A.PostGuard.slnx, and was merged in test: cover API clients, zip and seal pipeline #36.
• It covers every critical path this issue lists:
  • BuildPolicyJson — Email/EmailDomain (including EmailDomain with no @ → raw value), multiple extra attributes appended after the base, multiple recipients, unknown BaseType throws.
  • CryptifyClient chunked upload — Content-Range formatting per chunk and on finalize, token rotation across init → chunks → finalize, init/finalize URL wiring, recipient join, notify options, and the error paths (missing uuid/token, non-success).
  • PkgClient — MPK parsing (string and object publicKey, missing key, non-success) and signing-key parsing (pub/priv present, absent priv, null priv, missing pub, non-success).
  • ZipHelper — single/multiple files, nested paths, empty list, binary round-trip.

Verified locally on net10.0 (this workspace ships the net10.0 SDK but not the net8.0 runtime, so --framework net8.0 can't be executed here; both TFMs compile and CI runs both):

Passed!  - Failed: 0, Passed: 61, Skipped: 0, Total: 61 - E4A.PostGuard.Tests.dll (net10.0)

Remaining item: wire dotnet test into CI

.github/workflows/build.yml still has no test step (the job is named "Build and test" but only builds and packs). This agent's GitHub App lacks workflows: write, so it cannot push changes under .github/workflows/. Here is the copy-pastable patch — it inserts a Test step between Build and Pack (dry run), reusing the existing build output:

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 609b2cb..e8a8e28 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -42,6 +42,9 @@ jobs:
       - name: Build
         run: dotnet build E4A.PostGuard.slnx --configuration Release
 
+      - name: Test
+        run: dotnet test E4A.PostGuard.slnx --configuration Release --no-build
+
       - name: Pack (dry run)
         run: dotnet pack src/E4A.PostGuard.csproj --configuration Release --no-build --output ./artifacts
 

CI already installs both the 8.0.x and 10.0.x SDKs via setup-dotnet, so dotnet test exercises both target frameworks. Once this is applied to main, issue #10 is fully resolved — no further code change is needed.

@rubenhensen — if granting workflows: write to the app is on the table, it would let this kind of CI change land as a normal PR instead of a hand-applied patch (it comes up repeatedly).

[dobby-coder]

Good news: the test project was already merged in PR #36 — 61/61 tests passing on net10.0, covering all the critical paths from the issue (BuildPolicyJson, CryptifyClient chunked upload, PkgClient parsing, ZipHelper). No duplicate PR needed.

The one remaining piece is wiring dotnet test into .github/workflows/build.yml. I've left a verified, copy-pastable unified-diff patch in this comment — just apply it and CI will pick up the tests automatically. Closing this issue once that's in!