Skip to content

Commit 06c08df

Browse files
committed
feat(filesharing): only require email on sign step; name is optional
Remove the mandatory name disjunction from SIGN_ATTRIBUTES so senders only need to prove their email address (the pre-#239 UX). The condiscon infrastructure in postguard/pg-js remains available for future use. Update locale strings to no longer mention the name requirement.
1 parent fbed49c commit 06c08df

3 files changed

Lines changed: 6 additions & 31 deletions

File tree

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,12 @@
11
import type { AttrConItem } from '@e4a/pg-js'
22

33
/**
4-
* Yivi attributes the sender must (or may) disclose when signing a
5-
* PostGuard file share. The PostGuard PKG prepends the email attribute,
6-
* so it's not listed here.
7-
*
8-
* The first entry is the **mandatory name disjunction** — the sender
9-
* proves their name from any one of four credentials:
10-
*
11-
* - `pbdf.gemeente.personalData.fullname` (Dutch municipality), OR
12-
* - `pbdf.pbdf.passport.{firstName,lastName}`, OR
13-
* - `pbdf.pbdf.idcard.{firstName,lastName}`, OR
14-
* - `pbdf.pbdf.drivinglicence.{firstName,lastName}`.
15-
*
16-
* The remaining entries are unchanged optional extras from before
17-
* postguard#239 — kept in the legacy flat shape with `optional: true`.
4+
* Yivi attributes the sender may optionally disclose when signing a
5+
* PostGuard file share. The PostGuard PKG prepends the mandatory email
6+
* attribute, so it's not listed here. Everything here is optional — the
7+
* sender only needs to prove their email address.
188
*/
199
export const SIGN_ATTRIBUTES: AttrConItem[] = [
20-
[
21-
[{ t: 'pbdf.gemeente.personalData.fullname' }],
22-
[
23-
{ t: 'pbdf.pbdf.passport.firstName' },
24-
{ t: 'pbdf.pbdf.passport.lastName' },
25-
],
26-
[
27-
{ t: 'pbdf.pbdf.idcard.firstName' },
28-
{ t: 'pbdf.pbdf.idcard.lastName' },
29-
],
30-
[
31-
{ t: 'pbdf.pbdf.drivinglicence.firstName' },
32-
{ t: 'pbdf.pbdf.drivinglicence.lastName' },
33-
],
34-
],
3510
{ t: 'pbdf.sidn-pbdf.mobilenumber.mobilenumber', optional: true },
3611
{ t: 'pbdf.gemeente.personalData.dateofbirth', optional: true },
3712
]

src/lib/locales/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@
202202
"emailSender": "Email address",
203203
"emailSenderHeading": "Your information",
204204
"emailSenderSubHeadingToggle": "Why do you need this information?",
205-
"emailSenderSubHeading": "Let the recipient(s) know these files are from you. Before sending, you sign the files with the Yivi app by proving your email address and your name (from a Dutch municipality credential, or from a passport, ID card, or driving licence).",
205+
"emailSenderSubHeading": "Let the recipient(s) know these files are from you. Before sending, you sign the files with the Yivi app by proving your email address.",
206206
"messageHeading": "Message (optional)",
207207
"messageText": "This message will not be encrypted and will be included in the notification email.",
208208
"messagePlaceholder": "Type your message here...",

src/lib/locales/nl.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@
201201
"emailSender": "E-mailadres",
202202
"emailSenderHeading": "Jouw gegevens",
203203
"emailSenderSubHeadingToggle": "Waarom heb je deze gegevens nodig?",
204-
"emailSenderSubHeading": "Laat de ontvanger(s) weten dat deze bestanden van jou afkomstig zijn. Voor het verzenden onderteken je de bestanden met de Yivi-app door je e-mailadres en je naam aan te tonen (afkomstig uit je gemeente, paspoort, ID-kaart of rijbewijs).",
204+
"emailSenderSubHeading": "Laat de ontvanger(s) weten dat deze bestanden van jou afkomstig zijn. Voor het verzenden onderteken je de bestanden met de Yivi-app door je e-mailadres aan te tonen.",
205205
"messageHeading": "Bericht (optioneel)",
206206
"messageText": "Dit bericht wordt niet versleuteld en wordt opgenomen in de notificatie-e-mail.",
207207
"messagePlaceholder": "Typ hier je bericht...",

0 commit comments

Comments
 (0)