Non-blocking follow-up items from review of #234 (now merged). Both inline review threads on that PR were resolved; these are optional/nit suggestions from the review body that weren't tied to a specific line and were not addressed before merge.
Items
1. Declare the implicit node>=20 floor in package.json
prettier-plugin-svelte@4.0.0 bumps its own engines.node to >=20, so the repo now has an implicit Node 20 floor without a top-level engines key. CI runs Node 24 so it's fine in practice, but a contributor on Node 18 would get an EBADENGINE warning on install with no documented signal that the floor moved.
2. Upstream tracking link for the prettier-plugin-svelte workaround
The repo-side workaround in src/lib/components/filesharing/SendButton.svelte (moving the {@const} ternary into a script-level $derived) exists because of an upstream prettier-plugin-svelte bug — BinaryExpression inside a {@const} ternary. There's no upstream issue # referenced from the PR or commit, so a future maintainer has no signal for when the workaround can be reverted.
Out of scope (intentionally skipped)
- The two inline review threads on
SendButton.svelte (scope-widening note and locality-of-reference nit) are both already resolved.
- The review body also flagged "no automated test for the rewrite" but explicitly noted it isn't worth the cost given there's no component-level test harness for this calculation — skipping.
Source PR: #234
Non-blocking follow-up items from review of #234 (now merged). Both inline review threads on that PR were resolved; these are optional/nit suggestions from the review body that weren't tied to a specific line and were not addressed before merge.
Items
1. Declare the implicit
node>=20floor inpackage.jsonprettier-plugin-svelte@4.0.0bumps its ownengines.nodeto>=20, so the repo now has an implicit Node 20 floor without a top-levelengineskey. CI runs Node 24 so it's fine in practice, but a contributor on Node 18 would get anEBADENGINEwarning on install with no documented signal that the floor moved.package.json"engines": { "node": ">=20" }at the top level2. Upstream tracking link for the prettier-plugin-svelte workaround
The repo-side workaround in
src/lib/components/filesharing/SendButton.svelte(moving the{@const}ternary into a script-level$derived) exists because of an upstreamprettier-plugin-sveltebug —BinaryExpressioninside a{@const}ternary. There's no upstream issue # referenced from the PR or commit, so a future maintainer has no signal for when the workaround can be reverted.SendButton.sveltecan be retired when upstream is fixed.Out of scope (intentionally skipped)
SendButton.svelte(scope-widening note and locality-of-reference nit) are both already resolved.Source PR: #234