fix: npm run format script glob matches only directories#219
Merged
Conversation
The format script used 'prettier --write src/**/' where the trailing slash
made the glob match directories only, so prettier never actually formatted
files. Change to 'prettier --write .' to mirror the existing lint script
('prettier --check .'). .prettierignore already excludes generated content.
Closes #216
Contributor
Author
|
Trimmed the PR body — the original had a justification paragraph that's overkill for a one-line script fix (per the no-justification-paragraphs-for-simple-changes rule). The diff is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatscript fromprettier --write src/**/(matched only directories) toprettier --write ., mirroringlint(prettier --check .)..prettierignorealready scopes the file set.npm run formatandnpm run lintboth pass locally.Reviewer quickstart:
Closes #216