Add clipping to CenterWidgetGroup rectangle#3491
Open
khuza08 wants to merge 1 commit into
Open
Conversation
|
Finally, someone tried fixing it. However, it still a mess with your fix. |
- Add clip: true to CenterWidgetGroup to prevent overflow bleed - Replace ColumnLayout pair with anchor-based container so center smoothly fades out while bottom calendar grows to fill the space - Expose collapsedHeight on BottomWidgetGroup for clean height binding - Eliminates instant layout jumps (Layout.fillHeight) that caused a flash at screen scales > 1x
Author
if you want to hide the the center group when calendar is expanded, please try my new commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when scale is set above 1 (e.g. 1.2, 1.33, 1.5) and the bottom widget group (calendar/todo/timer) is expanded, the notification area gets squeezed, causing PagePlaceholder "Nothing" icon and text overflow outside CenterWidgetGroup bounds and render on top of the toggles and calendar, sorry bad english.
Comparison
Describe your changes
Add
clip: trueto theCenterWidgetGroupRectangle.Rectangle { id: root + clip: true radius: Appearance.rounding.normal color: Appearance.colors.colLayer1Is it ready? Questions/feedback needed?
yes, its simple fix