feat(compartment-mapper): a simple version of allowing exports override via define semantics with little new consequences

Author: naugtur

packages/compartment-mapper/src/parse-cjs-shared-export-wrapper.js

@@ -135,43 +135,7 @@ export const wrap = ({
     },
   });
 
-  let finalExports = originalExports;
-
-  // This might need some work on fidelity of the define semantics, but I feel bad about making it even more lines
-  const moduleHandler = {
-    get(target, prop) {
-      if (prop === 'exports') {
-        return finalExports;
-      }
-      return target[prop];
-    },
-    set(target, prop, value) {
-      if (prop === 'exports') {
-        finalExports = value;
-      }
-      return true;
-    },
-    defineProperty(target, prop, descriptor) {
-      if (prop === 'exports') {
-        if (descriptor.configurable === false) {
-          // For non-configurable properties, we must define it on the target because ECMAScript spec says so
-          defineProperty(target, prop, descriptor);
-        }
-        if (has(descriptor, 'value')) {
-          finalExports = descriptor.value;
-          return true;
-        }
-        if (has(descriptor, 'get')) {
-          finalExports = descriptor.get();
-          return true;
-        }
-      }
-      // Seems like there are no reasonable other fields anyone would define https://github.com/search?q=%22Object.defineProperty%28module%2C%22&type=code
-      return false;
-    },
-  };
-
-  const module = new Proxy({}, moduleHandler);
+  const module = { exports: originalExports };
 
   /** @param {string} importSpecifier */
   const require = importSpecifier => {
@@ -219,6 +183,7 @@ export const wrap = ({
   freeze(require);
 
   const afterExecute = () => {
+    const finalExports = module.exports; // in case it's a getter, only call it once
     const exportsHaveBeenOverwritten = finalExports !== originalExports;
     // Promotes keys from redefined module.export to top level namespace for import *
     // Note: We could do it less consistently but closer to how node does it if we iterated over exports detected by